Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restruct simple lottery #118

Merged
merged 13 commits into from
Jan 21, 2025
Merged

Restruct simple lottery #118

merged 13 commits into from
Jan 21, 2025

Conversation

rrtoledo
Copy link
Collaborator

@rrtoledo rrtoledo commented Jan 2, 2025

Content

Blocked by #116.

This PR aims at restructuring the Simple Lottery code (similarly to PR #116 for Centralized telescope) to have a user facing structure from which we can directly prove and verify. More particularly,

  • Moves code in implementation block
  • Moves implementation block in struct file
  • Renamed the user facing wrapper structure
  • Removed the user parameter structure and renamed the internal parameter structure

Additionnally, this PR

  • Fixed error in proof generation
  • Add documentation to public facing functions

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)

Comments

Issue(s)

Relates to #59

curiecrypt
curiecrypt previously approved these changes Jan 21, 2025
@rrtoledo rrtoledo force-pushed the raph@restruct-lotto branch from 397fce8 to 3db171e Compare January 21, 2025 13:20
@rrtoledo rrtoledo merged commit b22e571 into main Jan 21, 2025
1 check passed
@rrtoledo rrtoledo deleted the raph@restruct-lotto branch January 21, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants