Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ? placeholder syntax in listRetiredPools. #2053

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Use ? placeholder syntax in listRetiredPools. #2053

merged 2 commits into from
Aug 20, 2020

Conversation

jonathanknowles
Copy link
Contributor

@jonathanknowles jonathanknowles commented Aug 20, 2020 •
edited
Loading

Issue Number

#2016

Overview

This PR adjusts listRetiredPools to use the ? placeholder syntax when constructing a raw SQL query.

@jonathanknowles jonathanknowles self-assigned this Aug 20, 2020
@jonathanknowles

This comment has been minimized.

Sign in to view
iohk-bors bot added a commit that referenced this pull request Aug 20, 2020
@iohk-bors
Try #2053:
e2fc101
@jonathanknowles jonathanknowles mentioned this pull request Aug 20, 2020
Merged
2 tasks
@iohk-bors

This comment has been minimized.

Sign in to view
@jonathanknowles
Copy link
Contributor Author

bors try

iohk-bors bot added a commit that referenced this pull request Aug 20, 2020
@iohk-bors
Try #2053:
aec897a
@jonathanknowles jonathanknowles marked this pull request as ready for review August 20, 2020 08:51
@jonathanknowles jonathanknowles added the Improvement Mark a PR as an improvement, for auto-generated CHANGELOG label Aug 20, 2020
@jonathanknowles
Copy link
Contributor Author

bors cancel

@jonathanknowles
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 20, 2020
@iohk-bors @jonathanknowles
Merge #2053
2009aea 
2053: Use ? placeholder syntax in `listRetiredPools`. r=jonathanknowles a=jonathanknowles

# Issue Number

#2016 

# Overview

This PR adjusts `listRetiredPools` to use the `?` placeholder syntax when constructing a raw SQL query.

Co-authored-by: Jonathan Knowles <jonathan.knowles@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 20, 2020

Build failed

@jonathanknowles
Copy link
Contributor Author

bors retry

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 20, 2020

try

Build succeeded

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 20, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit c84ac72 into master Aug 20, 2020
@iohk-bors iohk-bors bot deleted the jonathanknowles/use-placeholders-in-sql-queries branch August 20, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

Assignees

@jonathanknowles jonathanknowles

Labels
Improvement Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Milestone
(ADP-376) Garbage collection of retir...
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanknowles @KtorZ