Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/transaction withdrawals #363

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Conversation

rhyslbw
Copy link
Collaborator

@rhyslbw rhyslbw commented Sep 22, 2020

Context

Closes #352

Proposed Solution

  1. Include withdrawals as another supplier of funds to the transaction, shown under from
    203b945b7123edbccff3dd35fa44456801872f56c773b9d35e4c5ccd747e5778
    screenshot_1
  2. When searching for a stake address, show a summary of the withdrawals made. When we have ledger state available, this screen can include a balance of the account too.
    stake1u8gu2vzsk2nc6hsphudhl3p6aum7nd59ajqjg9zp00uvxcqwsdray
    screenshot_2

http://deploy-preview-363--cardano-explorer-mainnet.netlify.app

Withdrawals from reward accounts are displayed alongside
transaction inputs in the 'from' section.

Closes #352
@rhyslbw rhyslbw added the enhancement New feature or request label Sep 22, 2020
searchForAddress is now separated into searchForPaymentAddress and
searchForStakeAddress, determined by using the bech32 prefix.

Closes #352
@rhyslbw rhyslbw force-pushed the feature/transaction-withdrawals branch from 69246a9 to c8ee6a2 Compare September 22, 2020 13:06
@rhyslbw rhyslbw added this to the 1.2.0 milestone Sep 22, 2020
Copy link
Contributor

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code quality & specs 👏 (note: I haven't tested the UI, only code review)

@rhyslbw rhyslbw merged commit 3f419d1 into develop Sep 22, 2020
@rhyslbw rhyslbw deleted the feature/transaction-withdrawals branch September 22, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reward withdrawals and stake addresses are not found or included in the UI
3 participants