Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deposits and refunds are not presented in the transaction summary #353

Closed
ntfreem opened this issue Sep 3, 2020 · 0 comments · Fixed by #361
Closed

Deposits and refunds are not presented in the transaction summary #353

ntfreem opened this issue Sep 3, 2020 · 0 comments · Fixed by #361
Milestone
1.2.0

Comments

@ntfreem
Copy link

ntfreem commented Sep 3, 2020 •
edited by rhyslbw
Loading

Summary

The Cardano explorer does not show deposits or refunds when say registering a staking key. So upon initial analysis of inputs and outputs, some transactions look unbalanced.

Steps to reproduce

Register a staking key and check the explorer

Example transaction below:

https://explorer.cardano-testnet.iohkdev.io/en/transaction?id=b2c2f15aa19192f87f14041a787e2534873553bc047bfbbf56b9a1c6cd69c021

Expected results

All key deposits should be shown on the blockchain

Actual results

At the moment there is no indication of any key deposit transaction or otherwise. Instead, we only see a balance increase.

Conclusion

The explorer should also report withdrawals key deposits
@rhyslbw rhyslbw added this to the 1.1.0 milestone Sep 16, 2020
@rhyslbw rhyslbw changed the title Cardano explorer -> not showing key deposits Cardano explorer -> not showing deposits Sep 17, 2020
@rhyslbw rhyslbw changed the title Cardano explorer -> not showing deposits Deposits from transactions are not presented in the transaction summary Sep 17, 2020
@rhyslbw rhyslbw changed the title Deposits from transactions are not presented in the transaction summary Deposits are not presented in the transaction summary Sep 17, 2020
@rhyslbw rhyslbw changed the title Deposits are not presented in the transaction summary Deposits and refunds are not presented in the transaction summary Sep 17, 2020
@rhyslbw rhyslbw mentioned this issue Sep 17, 2020
Closed
@rhyslbw rhyslbw modified the milestones: 1.1.0, 1.2.0 Sep 17, 2020
rhyslbw added a commit that referenced this issue Sep 18, 2020
@rhyslbw
feat: show deposits and reclaims when present in transaction
c609280 
Shows Deposit or Deposit Reclaim in the TransactionInfo when present in
transaction

Closes #353
rhyslbw added a commit that referenced this issue Sep 18, 2020
@rhyslbw
feat: show deposits and reclaims when present in transaction
6eafd39 
Shows Deposit or Deposit Reclaim in the TransactionInfo when present in
transaction

Closes #353
@rhyslbw rhyslbw mentioned this issue Sep 18, 2020
Merged
rhyslbw added a commit that referenced this issue Sep 21, 2020
@rhyslbw
feat: show deposits and reclaims when present in transaction
5791119 
Shows Deposit or Deposit Reclaim in the TransactionInfo when present in
transaction

Closes #353
rhyslbw added a commit that referenced this issue Sep 21, 2020
@rhyslbw
feat: show deposits and reclaims when present in transaction
3d00a35 
Shows Deposit or Deposit Reclaim in the TransactionInfo when present in
transaction

Closes #353
rhyslbw added a commit that referenced this issue Sep 25, 2020
@rhyslbw
Release/1.2.0 (#365)
af904c5 
* chore: update to cardano-graphql 2.2.0-beta

use new combined schema in package, removing local build step

* feat: show deposits and reclaims when present in transaction

Shows Deposit or Deposit Reclaim in the TransactionInfo when present in
transaction

Closes #353

* feat: add withdrawals to TransactionInfo
Withdrawals from reward accounts are displayed alongside
transaction inputs in the 'from' section.

Closes #352

* feat: resolve stake address searches based on withdrawals

searchForAddress is now separated into searchForPaymentAddress and
searchForStakeAddress, determined by using the bech32 prefix.

Closes #352

* feat: use stake pool hash over slot leader reference

when a block is created by a stake pool, the pool hash is now used. BFT
nodes still use the slot leader reference

Closes #355

* chore: bump versions, update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

feat: show deposits and reclaims when present in transaction cardano-foundation/cardano-explorer-app
2 participants
@rhyslbw @ntfreem