CIP5 updates #17
Merged
CIP5 updates #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KtorZ
commented
Aug 25, 2020
- Added a LICENSE file
- Make stake address keys prefixes consistent with address key prefixes
crptmppt
approved these changes
Aug 25, 2020
SebastienGllmt
approved these changes
Aug 25, 2020
dcoutts
approved these changes
Aug 25, 2020
Comment on lines
+34
to
+37
| | `stake_vk` | Stake address verification key | | ||
| | `stake_sk` | Stake address signing key | | ||
| | `stake_xvk` | Stake address extended verification key | | ||
| | `stake_xsk` | Stake address extended signing key | |
There was a problem hiding this comment.
👍 This is what both the wallet tools and node cli tools already use. So not only more sensible, but consistent with existing implementations.
crptmppt
added a commit
that referenced
this pull request
Mar 8, 2021
crptmppt
added a commit
that referenced
this pull request
Mar 8, 2021
KtorZ
added a commit
that referenced
this pull request
Jun 9, 2023
* Initial draft for dapp registration certificate spec * Init Draft CPS-0001 * Add Use Cases, improve descriptions * Typo * Generalizing CPS, simplifying problems and use cases. Add open questions * Add type key for REGISTER & UPDATE. Define rules for calculting hash of the metadata object tree * typoe fix * mistake folder added in last commit * Suggest metadata transaction labels for dapp registration and certification * Suggest metadata structure, off chain storages up to the operators. Improvements in schema and release properties * Refactor for more compliant header * Removing permissionToAggregate * Section for stores custom required metadata fields * Better descriptive title * Metadata links included in cert. Removing audits and simplify explanation * Update CIP-0072/README.md Co-authored-by: simonjohnthompson <s.j.thompson@kent.ac.uk> * Update CIP-0072/README.md Co-authored-by: simonjohnthompson <s.j.thompson@kent.ac.uk> * Update CIP-0072/README.md Co-authored-by: simonjohnthompson <s.j.thompson@kent.ac.uk> * typos, structure adjustments and small prose adds * Metadata links included in cert. Removing audits. Small refactoring * specify size of hash * Authors update * Delete sample-cip26.md * removing auditId * Add logo to suggested metadata properties * amendments based on comments / experience / feedback. * re-intro website + added regex patterns. * Update CIP-0072/README.md Co-authored-by: Robert Phair <rphair@cosd.com> * example fixes and adjusting to CIP template * added placeholders * added rationale section * fixes in rationale section * more rationale * fixed on-chain signature scope * categories * typo fixes * word wrapping test * cosmetics * cosmetics * Path to Active * more community comments * Fixes according to feedback * CIP version is mandatory, releases is optional, new algo to calculate signature * signature generation: hex vs byte array clarification * formatting fixes * added version description and more decisions rationale * typo fix * Fixed patterns for hex strings, added changed DE-REGISTER to DE_REGISTER and added new DE_REGISTER_ALL, schema version changed from 04 to 2019-07. * fixed several outdated things across CIP (#16) * removed several outdated things across CIP * addressed all comments on initial commit * Allow to express longer metadata URLs as an array of strings (#17) * latest changes as per last meeting agreements * Update README.md * Update README.md * CDDL * CDDL fix * cosmetics * initial categories update * security_vulnerability field, added comment field in on-chain json and recommendation for keeping all past histories of off-chain snapshots. * Update CIP-0072/README.md Co-authored-by: Marcin Mazurek <marcin@mazurek.pro> * latest comment fixes * Apply suggestions from code review Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com> * changes according to the recent comments * correction on Acceptance Criteria --------- Co-authored-by: simonjohnthompson <s.j.thompson@kent.ac.uk> Co-authored-by: Ryan Williams <rwilliams1@firstderivatives.com> Co-authored-by: Mateusz Czeladka <mateusz.czeladka@cardanofoundation.org> Co-authored-by: matiwinnetou <mateusz.szczap@gmail.com> Co-authored-by: Robert Phair <rphair@cosd.com> Co-authored-by: Volodymyr Hulchenko <57362128+vhulchenko-iohk@users.noreply.github.com> Co-authored-by: Marcin Mazurek <marcin@mazurek.pro> Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com> Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.