-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 9.1.0 & CNTools major bump #1783
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Adds a couple of new larger features within CNTools: - Multisig wallet support through advanced menu item. - Custom mnemonic derivation path on mnemonic/hardware import and creation of new mnemonic(seedphrase) generated wallet. - New Vote menu option to hold everything related to voting on Cardano incl Catalyst registration integration. Task List: - [x] Derive multisig keys according to CIP-1854 for mnemonic and hardware wallets, or new cli keys - [x] Create a multisig wallet specifying participants by wallet selection or manual cred input. - [x] Time lock support using after directive. - [x] Constructed using atLeast directive allowing any number of signatures. - [x] Wallet list/show extended to show additional details - [x] normal wallets: key credentials (both multisig keys and regular keys). - [x] multisig wallets: script parsing to show participants, either local wallets or external with credentials. - [x] All transaction building code updated to handle payment and stake scripts in addition to normal keys. If a multisig wallet is detected, an offline transaction file is generated just like in hybrid mode. - [x] Transaction >> Sign: updated to handle scripts in offline json tx file. - [x] Script validation logic to know if enough signatures have been added before assembly. - [x] Ability to create new mnemonic wallet (seedphrase). - [x] Allows for custom account and index derivation for mnemonic and hardware wallets. - [x] Removed CIP95 SPO poll - [x] New Catalyst registration option. - [x] Prerequisites: - [x] cardano-signer created by @gitmachtl. Can be deployed using `guild-deploy.sh -s x`. - [x] catalyst-toolbox compiled from catalyst-core and hosted through Koios share. Automatically downloaded within CNTools if needed. - [x] Uses CIP-36 style format with a single delegation - [x] Vote keys not derived from 1694' derivation path but cli generated for all types. - [x] Ability to verify catalyst registration and check status, both own and external vote pub keys. - [x] New Catalyst QR option to display previously generated QR code - [x] bump version - [x] update changelog - [x] tested and ready for alpha merge --------- Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>
…r if deriving keys and print on wallet show to know where keys come from, account and index.
… a few other buildTx locations
… to fix withdrawRewards
…tors into node-9.0.0
… failures in most of the remaining cntools commands
…registration as a part of vote delegation
2. Update node-cli documentation to include sample topology.json for Core node 3. Update upgrade.md for generic instructions and update basics.md for guild-deploy updates 4. Rename valency to hotValency in topology samples as valency is supposedly deprecated
…ser to make sure correct version is deployed.
Scitz0
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cardano_build_info
to fetch node version from runtimecardano_node_metrics_forging_enabled
to test if node is in Block Producing mode