Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 small simplifications in member access #5055

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Mar 3, 2025

  • IsInstanceMethod can look in the function's self_param_id instead of iterating through all of the implicit parameter patterns.
  • An associated entity is always associated with a single interface, so we don't need to handle the case when it isn't.

@jonmeow
Copy link
Contributor

jonmeow commented Mar 3, 2025

Can you please update the PR title to give a brief mention of what's being simplified?

Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but would appreciate a clearer PR title, and maybe a brief description, before merging.

@josh11b
Copy link
Contributor Author

josh11b commented Mar 3, 2025

LG, but would appreciate a clearer PR title, and maybe a brief description, before merging.

Done.

@josh11b josh11b added this pull request to the merge queue Mar 3, 2025
@jonmeow jonmeow removed this pull request from the merge queue due to a manual request Mar 3, 2025
@jonmeow
Copy link
Contributor

jonmeow commented Mar 3, 2025

LG, but would appreciate a clearer PR title, and maybe a brief description, before merging.

Done.

PR title doesn't appear to have changed?

@jonmeow
Copy link
Contributor

jonmeow commented Mar 3, 2025

Note, I'm not expecting much -- like "2 small simplifications in member access" would be fine. Just trying to have it noted in the PR description which area of the code base is affected, for anybody skimming PR titles.

@josh11b josh11b changed the title 2 small simplifications 2 small simplifications in member access Mar 3, 2025
@josh11b josh11b added this pull request to the merge queue Mar 3, 2025
Merged via the queue into carbon-language:trunk with commit 4fd273a Mar 3, 2025
10 checks passed
@josh11b josh11b deleted the clean branch March 3, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants