Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiline incremental sync. #5046

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Fix multiline incremental sync. #5046

merged 3 commits into from
Feb 28, 2025

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Feb 28, 2025 •
edited
Loading

Previously the start index was incorrect. Adding comments where I was double-checking things along the way.

@github-actions github-actions bot requested a review from geoffromer February 28, 2025 22:47
chandlerc
chandlerc approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@chandlerc chandlerc enabled auto-merge February 28, 2025 22:53
@chandlerc chandlerc added this pull request to the merge queue Feb 28, 2025
Merged via the queue into carbon-language:trunk with commit dc0c262 Feb 28, 2025
8 checks passed
@jonmeow jonmeow deleted the sync-multi-line branch March 3, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc approved these changes

@geoffromer geoffromer Awaiting requested review from geoffromer

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonmeow @chandlerc