Consolidate parse function tests #5039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
geoffromer
reviewed
Feb 27, 2025
There was a problem hiding this comment.
I have some reservations about how heavily we're leaning on file splits, for reasons I discussed a bit here, but this does make these tests more consistent with the tests we've written more recently.
| @@ -8,13 +8,35 @@ | |||
| // TIP: To dump output, run: | |||
| // TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/parse/testdata/function/definition/builtin.carbon | |||
|
|
|||
There was a problem hiding this comment.
Why not merge these into definition.carbon?
| @@ -8,8 +8,153 @@ | |||
| // TIP: To dump output, run: | |||
| // TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/parse/testdata/function/declaration/basic.carbon | |||
|
|
|||
There was a problem hiding this comment.
Should we maybe get rid of the whole declaration directory, and move this file to function/declaration.carbon?
There was a problem hiding this comment.
Sure, I'd been on the fence about it but not sure we'd have split dirs if we had split files before. Also merged the two extern.carbon's this way.
geoffromer
approved these changes
Feb 28, 2025
bb68342 to
24c69f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests pretty much predate split tests. There are lots of files as a result, and I think consolidation will help (hopefully others agree).