Don't use an impl when 'extend impl' is an error #4935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If 'extend impl' is invalid, mark the impl as invalid by putting an ErrorInst in the witness_id field. The construction of the witness_id can otherwise return an ErrorInst but impl lookup was not checking for that. Now have impl lookup check for an error there before attempting to deduce generic parameters, which avoids infinite recursion through deduction in cases like a cyclical impl of itself. Adds a testcase for infinite impl-of-itself lookup found by fuzzer.
6438cb0 to
8f89853
Compare
josh11b
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If 'extend impl' is invalid, mark the impl as invalid by putting an ErrorInst in the witness_id field.
The construction of the witness_id can otherwise return an ErrorInst but impl lookup was not checking for that. Now have impl lookup check for an error there before attempting to deduce generic parameters, which avoids infinite recursion through deduction in cases like a cyclical impl of itself.
Adds a testcase for infinite impl-of-itself lookup found by fuzzer.