Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop macos-12 runners due to shutdown #4412

Merged
merged 1 commit into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/actions/build-setup-macos/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@ runs:
xcrun simctl delete all
sudo rm -rf ~/Library/Developer/CoreSimulator/Caches/*

# Install and cache LLVM 16 from Homebrew.
# TODO: We can potentially remove this and simplify things when the
# Homebrew version of LLVM updates to 16 here:
# https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md
# Install and cache LLVM 16 from Homebrew. Some runners may have LLVM 16,
# but this is reliable (including with libc++), and gives us testing at the
# minimum supported LLVM version.
- name: Cache Homebrew
id: cache-homebrew-macos
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,8 @@ jobs:
test:
strategy:
matrix:
# On PRs and in the merge queue test a recent version of each supported
# OS. On push (post-submit), also run on `macos-12` to get Intel macOS
# coverage.
runner:
${{ fromJSON(github.event_name != 'push' && '["ubuntu-22.04",
"macos-14"]' || '["ubuntu-22.04", "macos-14", "macos-12"]') }}
# Test a recent version of each supported OS.
runner: ['ubuntu-22.04', 'macos-14']
build_mode: [fastbuild, opt]
include:
# The clang-tidy config doesn't work on macos (missing `truncate`).
Expand Down
Loading