Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

where check stage, step 2: SemIR #4349

Merged
merged 31 commits into from
Sep 27, 2024
Merged

where check stage, step 2: SemIR #4349

merged 31 commits into from
Sep 27, 2024

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Sep 26, 2024 •
edited
Loading

The check stage now produces SemIR instructions to represent a where clause. It still does not check types.

josh11b and others added 29 commits September 19, 2024 21:01
@josh11b
Checkpoint progress.
343ddaa
@josh11b
Checkpoint progress.
cddc74a
@josh11b
Checkpoint progress.
c28c94d
@josh11b
Checkpoint progress.
b5c880e
@josh11b
Add tests
69448d3
@josh11b
Merge remote-tracking branch 'upstream/trunk' into whereck
9a54bb4
@josh11b
Fix formatting
e88fd4c
@josh11b
Checkpoint progress.
c7959f1
@josh11b @jonmeow
Apply suggestions from code review
7a009a5 
Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
@josh11b
Fix formatting
b9c2b6d
@josh11b
Checkpoint progress.
ca5b74a
@josh11b
Expand testing
fa152c0
@josh11b
Checkpoint progress.
70e51ca
@josh11b
Checkpoint progress.
3f2e092
@josh11b
Use HandleNameAsExpr, plus fixes
8d2b455
@josh11b
TODO comment better
3c37013
@josh11b
Checkpoint progress.
7a81ddf
@josh11b
Simplify
3c81839
@josh11b
Note on error
531e5b5
@josh11b
Remove FIXME
6bf6262
@josh11b
Merge branch 'whereck' into req
67cfc6b
@josh11b
Checkpoint progress.
3d2c642
@josh11b
Merge remote-tracking branch 'upstream/trunk' into req
45a000e
@josh11b
Checkpoint progress.
41e42af
@josh11b
Checkpoint progress.
c0cce9c
@josh11b
Tests pass
475cd90
@josh11b
Merge remote-tracking branch 'upstream/trunk' into req
218d4ca
@josh11b
Attempt to fix instruction naming
af1685c
@josh11b
Checkpoint progress.
eda6945
@josh11b josh11b marked this pull request as draft September 26, 2024 20:57
@github-actions github-actions bot requested a review from chandlerc September 26, 2024 20:57
@josh11b josh11b changed the title where check stage, step 2: SemIr where check stage, step 2: SemIR Sep 26, 2024
@josh11b josh11b requested review from zygoloid and removed request for chandlerc September 26, 2024 22:19
@josh11b josh11b marked this pull request as ready for review September 26, 2024 22:19
@josh11b josh11b requested review from zygoloid and removed request for zygoloid September 26, 2024 22:19
@zygoloid zygoloid added this pull request to the merge queue Sep 27, 2024
Merged via the queue into carbon-language:trunk with commit bdbd107 Sep 27, 2024
11 checks passed
@josh11b josh11b deleted the req branch September 27, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid approved these changes

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josh11b @zygoloid