Convert CommandLine member references to pointers #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh11b
approved these changes
Sep 11, 2024
|
Discussion seems to be leaning towards more passing by reference, so I've changed that here. |
josh11b
approved these changes
Sep 13, 2024
chandlerc
reviewed
Sep 20, 2024
7873981 to
2cffb1e
Compare
|
That's fine, given the prior commit already had pointers I think it's easier to unroll to that here. I've also add "must not be null" comments per your style request. |
josh11b
approved these changes
Sep 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
[Context](https://discord.com/channels/655572317891461132/821113559755784242/1283516297686286377). Some relevant Google C++ style is at [Inputs and Outputs](https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs). #4301 is an example application of the style. --------- Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on a style question about whether to prefer reference members or pointers. This PR converts to pointers as a demonstration of that style choice.
Note, I'm trying to update constructors to match use of
*based on whether they keep a reference. I'm removing a fewconst&uses where no reference was kept (i.e., it was just copied, and didn't seem worth a move).I'm changing
AddArgImplto return anArg*because it just gets passed to a constructor, seems simpler this way.