Break out driver environment info into its own type. #4299
Conversation
toolchain/driver/driver.cpp
Outdated
| @@ -789,7 +792,7 @@ class Driver::CompilationUnit { | |||
| !input_filename_.starts_with(options_.exclude_dump_file_prefix); | |||
| } | |||
|
|
|||
| Driver* driver_; | |||
| DriverEnv& driver_env_; | |||
There was a problem hiding this comment.
I would prefer fields not to have a reference type, particularly non-const. Can this be made into a pointer instead? I see that some other fields are references too -- what is the motivation?
There was a problem hiding this comment.
Generally I think there's a mix in the toolchain, tending more to references than pointers. One constraint of references is that they're implicitly non-null.
There was a problem hiding this comment.
Perhaps as a stronger argument, three lines down there's a &. This type should be self-consistent.
https://discord.com/channels/655572317891461132/821113559755784242/1283516297686286377 regarding this.
There was a problem hiding this comment.
Trying to read a possible conclusion from current discussion, updated to DriverEnv*
I want to split commands out so that we don't keep piling onto driver (particularly as I'm eyeing clang-related commands). This extracts out the DriverEnv so that it can be easily shared, with the CompilationUnit as an example.
CARBON_VLOG_TO is to remove the vlog_stream_ requirement of CARBON_VLOG.