Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to use [[@TEST_NAME]] #4293

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Update tests to use [[@TEST_NAME]] #4293

merged 3 commits into from
Sep 10, 2024

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Sep 10, 2024 •
edited
Loading

Applies #4278 TEST_NAME substitution to tests. Note I've tried to structure commits as:

  1. Do all the replacements.
  2. autoupdate (nothing else) -- this shows incorrect updates.
  3. Fix up manually, including autoupdates to get back to original output.

@github-actions github-actions bot requested a review from josh11b September 10, 2024 22:35
@josh11b
Copy link
Contributor

josh11b commented Sep 10, 2024

Could you add a reference to the PR that introduced [[@TEST_NAME]]

@jonmeow
Copy link
Contributor Author

jonmeow commented Sep 10, 2024

Done

@josh11b josh11b added this pull request to the merge queue Sep 10, 2024
Merged via the queue into carbon-language:trunk with commit d4c7743 Sep 10, 2024
10 checks passed
@jonmeow jonmeow deleted the lib-use branch September 10, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid approved these changes

@josh11b josh11b josh11b approved these changes

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonmeow @josh11b @zygoloid