When using --dump_output with file_test, dump stderr directly. #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
approved these changes
Apr 22, 2024
chandlerc
pushed a commit
to chandlerc/carbon-lang
that referenced
this pull request
May 2, 2024
…n-language#3901) Right now, debugging a crash means errs never flushes: it's buffered in the string. As a consequence, -v doesn't print anything. By stopping the output capture in --dump_output, it prints directly for debugging.
CJ-Johnson
pushed a commit
to CJ-Johnson/carbon-lang
that referenced
this pull request
May 23, 2024
…n-language#3901) Right now, debugging a crash means errs never flushes: it's buffered in the string. As a consequence, -v doesn't print anything. By stopping the output capture in --dump_output, it prints directly for debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, debugging a crash means errs never flushes: it's buffered in the string. As a consequence, -v doesn't print anything. By stopping the output capture in --dump_output, it prints directly for debugging.