Add support for builtin float comparison operations #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppaglilla
commented
Apr 19, 2024
| @@ -200,6 +200,28 @@ static auto GetBuiltinICmpPredicate(SemIR::BuiltinFunctionKind builtin_kind, | |||
| } | |||
| } | |||
|
|
|||
| // Get the predicate to use for an `fcmp` instruction generated for the | |||
| // specified builtin. | |||
| static auto GetBuiltinFCmpPredicate(SemIR::BuiltinFunctionKind builtin_kind) | |||
There was a problem hiding this comment.
This is using the ordered variants of fcmp conditions, which I'm not sure is accurate with Carbon's intended behavior. Would love feedback on whether this is okay!
There was a problem hiding this comment.
Yes, using ordered comparisons is the intent. I don't think we state this explicitly, but it's implicitly mentioned here and here in the design.
zygoloid
approved these changes
Apr 19, 2024
| @@ -200,6 +200,28 @@ static auto GetBuiltinICmpPredicate(SemIR::BuiltinFunctionKind builtin_kind, | |||
| } | |||
| } | |||
|
|
|||
| // Get the predicate to use for an `fcmp` instruction generated for the | |||
| // specified builtin. | |||
| static auto GetBuiltinFCmpPredicate(SemIR::BuiltinFunctionKind builtin_kind) | |||
There was a problem hiding this comment.
Yes, using ordered comparisons is the intent. I don't think we state this explicitly, but it's implicitly mentioned here and here in the design.
chandlerc
pushed a commit
to chandlerc/carbon-lang
that referenced
this pull request
May 2, 2024
…3899) Adds support for builtin comparison operations for floats (`==`, `!=`, `<`, `<=`, `>`, `>=`).
CJ-Johnson
pushed a commit
to CJ-Johnson/carbon-lang
that referenced
this pull request
May 23, 2024
…3899) Adds support for builtin comparison operations for floats (`==`, `!=`, `<`, `<=`, `>`, `>=`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for builtin comparison operations for floats (
==,!=,<,<=,>,>=).