Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross-file links in non-proposal files #1010

Merged
merged 4 commits into from
Jan 7, 2022
Merged

Fix cross-file links in non-proposal files #1010

merged 4 commits into from
Jan 7, 2022

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Jan 6, 2022

@josh11b Note the question on Discord, for the facet type link in the generics overview.

@jonmeow jonmeow requested a review from josh11b January 6, 2022 00:52
@jonmeow jonmeow requested review from a team as code owners January 6, 2022 00:52
@jonmeow jonmeow mentioned this pull request Jan 6, 2022
Closed
chandlerc
chandlerc approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, this is so awesome. L-freaking-amazing-TM.

@jonmeow jonmeow merged commit 1334584 into carbon-language:trunk Jan 7, 2022
@jonmeow jonmeow deleted the fixier-linksier branch January 7, 2022 19:00
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@jonmeow
Fix cross-file links in non-proposal files (#1010)
b7df523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc approved these changes

@josh11b josh11b Awaiting requested review from josh11b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonmeow @chandlerc