Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Dana Jansens <danakj@orodu.net>
  • Loading branch information
josh11b and danakj authored Mar 3, 2025
1 parent 5571836 commit 270cf96
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions toolchain/check/impl_lookup.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ static auto GetWitnessIdForImpl(Context& context, SemIR::LocId loc_id,
// facet.
static auto FindWitnessInFacet(Context& context, SemIR::LocId loc_id,
SemIR::ConstantId facet_const_id,
SemIR::SpecificInterface& specific_interface)
const SemIR::SpecificInterface& specific_interface)
-> SemIR::InstId {
SemIR::InstId facet_inst_id =
context.constant_values().GetInstId(facet_const_id);
Expand All @@ -296,9 +296,9 @@ static auto FindWitnessInFacet(Context& context, SemIR::LocId loc_id,
for (auto interface : complete_facet_type.required_interfaces) {
if (interface == specific_interface) {
// TODO: Need to get the right witness when there are multiple.
return GetOrAddInst<SemIR::FacetAccessWitness>(
return GetOrAddInst(
context, loc_id,
{.type_id = GetSingletonType(context,
SemIR::FacetAccessWitness{.type_id = GetSingletonType(context,
SemIR::WitnessType::SingletonInstId),
.facet_value_inst_id = facet_inst_id});
}
Expand Down

0 comments on commit 270cf96

Please sign in to comment.