Apply suggestions from code review

Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
carbon-language · Nov 12, 2024 · 2138719 · 2138719
1 parent 311d0d1
commit 2138719
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/toolchain/base/timings.h b/toolchain/base/timings.h
@@ -25,7 +25,7 @@ class Timings {
       map.Add("filename", filename);
       map.Add("nanoseconds",
               Yaml::OutputMapping([&](Yaml::OutputMapping::Map label_map) {
-                auto total_nanoseconds = std::chrono::nanoseconds(0);
+                std::chrono::nanoseconds total_nanoseconds(0);
                 for (const auto& entry : timings_) {
                   total_nanoseconds += entry.nanoseconds;
                   label_map.Add(entry.label, entry.nanoseconds.count());

diff --git a/toolchain/check/check.cpp b/toolchain/check/check.cpp
@@ -958,9 +958,9 @@ static auto CheckParseTree(
   auto start_time = std::chrono::steady_clock::now();
   CheckParseTreeInner(node_converters, unit_info, total_ir_count, vlog_stream);
   auto end_time = std::chrono::steady_clock::now();
-  auto timings = unit_info.unit->timings;
-  if (timings) {
-    (*timings)->Add("check", end_time - start_time);
+  if (auto& timings = *(unit_info.unit->timings)) {
+    auto end_time = std::chrono::steady_clock::now();
+    timings->Add("check", end_time - start_time);
   }
 }
 

diff --git a/toolchain/check/check.h b/toolchain/check/check.h
@@ -20,7 +20,7 @@ namespace Carbon::Check {
 // Checking information that's tracked per file.
 struct Unit {
   SharedValueStores* value_stores;
-  std::optional<Timings*> timings;
+  std::optional<Timings>* timings;
   const Lex::TokenizedBuffer* tokens;
   const Parse::Tree* parse_tree;
   DiagnosticConsumer* consumer;

diff --git a/toolchain/driver/compile_subcommand.cpp b/toolchain/driver/compile_subcommand.cpp
@@ -432,7 +432,7 @@ class CompilationUnit {
     CARBON_CHECK(parse_tree_);
     return {
         .value_stores = &value_stores_,
-        .timings = &*timings_,
+        .timings = &timings_,
         .tokens = &*tokens_,
         .parse_tree = &*parse_tree_,
         .consumer = consumer_,
@@ -513,8 +513,8 @@ class CompilationUnit {
     CARBON_CHECK(module_);
     auto start_time = std::chrono::steady_clock::now();
     LogCall("CodeGen", [&] { success_ = RunCodeGenHelper(); });
-    auto end_time = std::chrono::steady_clock::now();
     if (timings_) {
+      auto end_time = std::chrono::steady_clock::now();
       timings_->Add("codegen", end_time - start_time);
     }
   }