Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to carbon 10.9.3 #341

Merged
merged 6 commits into from
Feb 4, 2020
Merged

chore: update to carbon 10.9.3 #341

merged 6 commits into from
Feb 4, 2020

Conversation

jendowns
Copy link
Contributor

Affected issues

Proposed changes

Testing instructions

  • Review the list of changes in the release notes & ensure nothing is a breaking change for us.
  • Check out our storybook to ensure that everything looks all right.

@jendowns jendowns requested a review from a team as a code owner January 31, 2020 21:01
@jendowns jendowns requested a review from SimonFinney January 31, 2020 21:01
@netlify
Copy link

netlify bot commented Jan 31, 2020 •
edited
Loading

Deploy preview for ibm-security ready!

Built with commit d13806a

https://deploy-preview-341--ibm-security.netlify.com

jendowns
jendowns commented Jan 31, 2020
View reviewed changes
Copy link
Contributor Author

@jendowns jendowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current known issue:

  • Tags - we need to reconcile our Tags and TagWall component with updates from Carbon

@jendowns jendowns mentioned this pull request Feb 3, 2020
Merged
@jendowns jendowns force-pushed the update-carbon-10.9.3 branch from ba8bd8c to d8038b9 Compare February 3, 2020 17:31
@jendowns
Copy link
Contributor Author

jendowns commented Feb 3, 2020

@SimonFinney I believe this is ready to review now 👍 The main thing to pay attention to IMO is the treatment of the Tag & InteractiveTag

SimonFinney
SimonFinney approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@SimonFinney SimonFinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 LGTM! I did a manual pass and everything seems great - thank you!

@jendowns jendowns merged commit 2a8caf2 into dev Feb 4, 2020
@jendowns jendowns deleted the update-carbon-10.9.3 branch February 4, 2020 15:18
@SimonFinney
Copy link
Contributor

🎉 This PR is included in version 1.16.1-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jendowns jendowns mentioned this pull request Feb 4, 2020
Closed
@SimonFinney
Copy link
Contributor

🎉 This PR is included in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SimonFinney
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonFinney SimonFinney SimonFinney approved these changes

Assignees
No one assigned
Labels
released on @canary released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SummaryCardBatchActions - buttons in tab order even when they appear "hidden"
2 participants
@jendowns @SimonFinney