Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: condition builder style issues #6724

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

amal-k-joy
Copy link
Contributor

Closes #6701

Move wrapper padding from component level to storyboook styles
Fix a style issue in popover

How did you test and verify your work?

local

@amal-k-joy amal-k-joy requested a review from a team as a code owner January 17, 2025 06:13
@amal-k-joy amal-k-joy requested review from davidmenendez and matthewgallo and removed request for a team January 17, 2025 06:13
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit d2ba79a
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/6789f5466e38a00008adbffe
😎 Deploy Preview https://deploy-preview-6724--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit d2ba79a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6789f546215b7d00084c41bc
😎 Deploy Preview https://deploy-preview-6724--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amal-k-joy amal-k-joy enabled auto-merge January 17, 2025 06:14
@amal-k-joy amal-k-joy requested a review from makafsal January 17, 2025 06:14
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (df21099) to head (d2ba79a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6724   +/-   ##
=======================================
  Coverage   80.90%   80.90%           
=======================================
  Files         398      398           
  Lines       12953    12953           
  Branches     4280     4280           
=======================================
  Hits        10480    10480           
  Misses       2473     2473           
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@amal-k-joy amal-k-joy added this pull request to the merge queue Jan 22, 2025
Merged via the queue into carbon-design-system:main with commit 37dba95 Jan 22, 2025
32 checks passed
@amal-k-joy amal-k-joy deleted the conditionbuilder6701 branch January 22, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ConditionBuilder style issues
3 participants