feat: add option to pass description to display on hover of properties #6718
+24
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6718 +/- ##
=======================================
Coverage 80.76% 80.76%
=======================================
Files 397 397
Lines 12970 12976 +6
Branches 4296 4298 +2
=======================================
+ Hits 10475 10480 +5
- Misses 2495 2496 +1
|
davidmenendez
requested changes
Jan 16, 2025
| ...rest | ||
| }: ConditionBuilderButtonProps) => { | ||
| const [tooltipText, setTooltipText] = useState(label); |
There was a problem hiding this comment.
this doesn't need to be set in state. you should be able to derive the value directly from props. tooltipText = description || label;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6717
Need to pass an optional description along with input properties and need to display that on mouse hover of property field
What did you change?
Added a description property to the input config to display on hover/focus of property field
How did you test and verify your work?
local