fix(Datagrid): onRowClick results in toggleRow.toggleRowSelected is not a function error in console #6633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6633 +/- ##
==========================================
- Coverage 80.78% 80.67% -0.12%
==========================================
Files 396 397 +1
Lines 12893 12923 +30
Branches 4274 4286 +12
==========================================
+ Hits 10415 10425 +10
- Misses 2478 2498 +20
|
AlexanderMelox
requested changes
Jan 7, 2025
Co-authored-by: Alexander Melo <alexandermelox@gmail.com>
anamikaanu96
approved these changes
Jan 13, 2025
AlexanderMelox
approved these changes
Jan 13, 2025
Merged
via the queue into
carbon-design-system:main
with commit Jan 13, 2025
82ce15c
32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6547
Added a null check for
toggleRowSelectedcallback since for some rows objects,toggleRowSelectedis not present.How did you test and verify your work?
local