fix(Condition builder): initial state getting reset on re-rendering #6555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6555 +/- ##
==========================================
+ Coverage 79.97% 80.00% +0.02%
==========================================
Files 394 394
Lines 12894 12896 +2
Branches 4273 4273
==========================================
+ Hits 10312 10317 +5
+ Misses 2582 2579 -3
|
davidmenendez
approved these changes
Dec 9, 2024
...products/src/components/ConditionBuilder/ConditionBuilderContent/ConditionBuilderContent.tsx
Show resolved
Hide resolved
sangeethababu9223
approved these changes
Dec 11, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 11, 2024
ea0989a
36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6457
Initial state issue fix.
What did you change?
Set the initial state to root state and clear initial state on manually deleting all conditions
How did you test and verify your work?
local