-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tearsheet): resolve focusing elements multiple times while rendering #6513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makafsal
requested review from
davidmenendez and
sangeethababu9223
and removed request for
a team
November 27, 2024 13:06
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6513 +/- ##
==========================================
+ Coverage 79.65% 79.84% +0.18%
==========================================
Files 394 394
Lines 12871 12859 -12
Branches 4257 4251 -6
==========================================
+ Hits 10253 10267 +14
+ Misses 2618 2592 -26
|
davidmenendez
approved these changes
Dec 3, 2024
sangeethababu9223
approved these changes
Dec 11, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 12, 2024
1c918d1
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6466
What did you change?
Refactored the
TearsheetShell
component and removed unwanted focus managementHow did you test and verify your work?
yarn avt
yarn test
Storybook