Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tearsheet): resolve focusing elements multiple times while rendering #6513

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

makafsal
Copy link
Member

Closes #6466

What did you change?

Refactored the TearsheetShell component and removed unwanted focus management

How did you test and verify your work?

yarn avt
yarn test
Storybook

@makafsal makafsal requested a review from a team as a code owner November 27, 2024 13:06
@makafsal makafsal requested review from davidmenendez and sangeethababu9223 and removed request for a team November 27, 2024 13:06
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit ecc0147
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6747f10626f6620008a4f17f
😎 Deploy Preview https://deploy-preview-6513--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit ecc0147
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/6747f106a66b610008370c0e
😎 Deploy Preview https://deploy-preview-6513--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.84%. Comparing base (473af0f) to head (ecc0147).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6513      +/-   ##
==========================================
+ Coverage   79.65%   79.84%   +0.18%     
==========================================
  Files         394      394              
  Lines       12871    12859      -12     
  Branches     4257     4251       -6     
==========================================
+ Hits        10253    10267      +14     
+ Misses       2618     2592      -26     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@makafsal makafsal added this pull request to the merge queue Dec 12, 2024
Merged via the queue into carbon-design-system:main with commit 1c918d1 Dec 12, 2024
33 checks passed
@makafsal makafsal deleted the fix-6466 branch December 12, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tearsheet: Element focussed twice when using stacked tearsheets
4 participants