fix: remove tooltip from tagoverflow #6463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6463 +/- ##
==========================================
- Coverage 79.85% 79.84% -0.02%
==========================================
Files 394 394
Lines 12877 12877
Branches 4258 4258
==========================================
- Hits 10283 10281 -2
- Misses 2594 2596 +2
|
makafsal
requested changes
Nov 19, 2024
amal-k-joy
requested changes
Nov 20, 2024
|
@amal-k-joy this appears to be working as intended as they are read only |
|
@makafsal coverage should be acceptable now 👍 |
makafsal
approved these changes
Dec 9, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 11, 2024
c6f0ac0
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5736
fixes an issue where the
Tagcomponent was being wrapped by abuttonfromTooltipwhich was causing aninvalid dom nestingerror. since carbon tags includetitlethey should already be screen reader accessible when they are being truncated.