Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APIKeyModal): implement focus return to generate button #6440

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

makafsal
Copy link
Member

Closes #6246

What did you change?

Implement new property launcherButtonRef

How did you test and verify your work?

yarn test
yarn avt

@makafsal makafsal requested a review from a team as a code owner November 15, 2024 09:29
@makafsal makafsal requested review from davidmenendez and devadula-nandan and removed request for a team November 15, 2024 09:29
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit f8aacdf
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67377b102f985a000817e2c7
😎 Deploy Preview https://deploy-preview-6440--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit f8aacdf
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67377b104af06c00082f11b3
😎 Deploy Preview https://deploy-preview-6440--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.59%. Comparing base (27fc332) to head (f8aacdf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6440   +/-   ##
=======================================
  Coverage   79.58%   79.59%           
=======================================
  Files         394      394           
  Lines       12861    12866    +5     
  Branches     4266     4267    +1     
=======================================
+ Hits        10236    10241    +5     
  Misses       2625     2625           
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devadula-nandan devadula-nandan added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@elycheea elycheea added this pull request to the merge queue Nov 15, 2024
Merged via the queue into carbon-design-system:main with commit 535e871 Nov 15, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: API key Modal, Focus not returning to triggering button
4 participants