chore(FilterPanel): deprecate filter panel and its sub components #6431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6431 +/- ##
==========================================
+ Coverage 79.61% 79.62% +0.01%
==========================================
Files 394 394
Lines 12871 12878 +7
Branches 4268 4268
==========================================
+ Hits 10247 10254 +7
Misses 2624 2624
|
davidmenendez
requested changes
Nov 15, 2024
packages/ibm-products/src/components/FilterPanel/FilterPanel.mdx
Outdated
Show resolved
Hide resolved
|
these are the initial snapshots, so 168 visual changes is expected, and must be approved in percy dashboard, until we merge any pr with approved visual changes, they keep appearing. |
…ucts into deplicateFilterPanel
sangeethababu9223
approved these changes
Nov 19, 2024
davidmenendez
approved these changes
Nov 20, 2024
Merged
via the queue into
carbon-design-system:main
with commit Nov 20, 2024
5fb804a
32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6320
What did you change?
Annotated deprecation notice in Filter panel and its sub stories
How did you test and verify your work?
storybook
yarn test