Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditionBuilder): address issues inside conditionBuilder popover #6421

Merged

Conversation

amal-k-joy
Copy link
Contributor

Closes #6402

  • Cannot type in to the search box to filter the list.
  • Dropdown auto closes after every time a checkbox is selected
  • Corrected a corrupt data for a storybook story

What did you change?

  • Removed preventDefault from search input. This will give carbon search input behaviour , which is to clear any search text on Escape keypress rather than closing the popover.
  • StopPropogation on checkbox icon click to prevent closing

How did you test and verify your work?

local

@amal-k-joy amal-k-joy requested a review from a team as a code owner November 13, 2024 07:03
@amal-k-joy amal-k-joy requested review from davidmenendez and matthewgallo and removed request for a team November 13, 2024 07:04
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 750c73d
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67344f61216e34000900dbaa
😎 Deploy Preview https://deploy-preview-6421--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 750c73d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67344f6165314d0008d90cdb
😎 Deploy Preview https://deploy-preview-6421--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amal-k-joy amal-k-joy changed the title fix(conditionBuilder): issue fix and data correction fix(conditionBuilder): address issues inside conditionBuilder popover Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.60%. Comparing base (365c310) to head (750c73d).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6421      +/-   ##
==========================================
+ Coverage   79.57%   79.60%   +0.02%     
==========================================
  Files         394      394              
  Lines       12840    12858      +18     
  Branches     4253     4264      +11     
==========================================
+ Hits        10217    10235      +18     
  Misses       2623     2623              
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@amal-k-joy amal-k-joy added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@amal-k-joy amal-k-joy added this pull request to the merge queue Nov 18, 2024
Merged via the queue into carbon-design-system:main with commit 1f5b63e Nov 18, 2024
33 checks passed
@amal-k-joy amal-k-joy deleted the conditionBuilderIssue6402 branch November 18, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ConditionBuilder issues
3 participants