feat(BreadcrumbWithOverflow): adopt overflowMenuV12 and floating ui #6411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6411 +/- ##
==========================================
+ Coverage 79.64% 79.85% +0.20%
==========================================
Files 394 394
Lines 12872 12877 +5
Branches 4257 4258 +1
==========================================
+ Hits 10252 10283 +31
+ Misses 2620 2594 -26
|
makafsal
reviewed
Nov 18, 2024
anamikaanu96
previously approved these changes
Nov 26, 2024
devadula-nandan
approved these changes
Nov 26, 2024
anamikaanu96
approved these changes
Nov 26, 2024
Merged
via the queue into
carbon-design-system:main
with commit Nov 26, 2024
f716852
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5493
Add floating-ui to BreadcrumbWithOverflow
What did you change?
Adopted carbon overflowMenuV12 by enabling the feature flag
enableV12OverflowmenuUpdated failed testcases
Updated to new props and used
MenuItemas children forOverflowMenuinstead ofOverflowMenuItemHow did you test and verify your work?
storybook