Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carousel): adds test coverage #6355

Conversation

AlexanderMelox
Copy link
Contributor

Closes #6261

Increases Carousel coverage

What did you change?

How did you test and verify your work?

Jest

@AlexanderMelox AlexanderMelox requested a review from a team as a code owner November 4, 2024 15:37
@AlexanderMelox AlexanderMelox requested review from matthewgallo and amal-k-joy and removed request for a team November 4, 2024 15:37
@AlexanderMelox AlexanderMelox marked this pull request as draft November 4, 2024 15:37
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 197210b
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/672a2b7e6e653800081cff91
😎 Deploy Preview https://deploy-preview-6355--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 197210b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/672a2b7e0e390500084e32c8
😎 Deploy Preview https://deploy-preview-6355--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlexanderMelox AlexanderMelox changed the title feat(carousel): starts adding tests feat(carousel): adds test coverage Nov 4, 2024
@AlexanderMelox AlexanderMelox marked this pull request as ready for review November 5, 2024 14:28
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.58%. Comparing base (62f3369) to head (197210b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6355      +/-   ##
==========================================
+ Coverage   79.28%   79.58%   +0.29%     
==========================================
  Files         395      394       -1     
  Lines       12886    12839      -47     
  Branches     4262     4253       -9     
==========================================
+ Hits        10217    10218       +1     
+ Misses       2669     2621      -48     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@matthewgallo matthewgallo added this pull request to the merge queue Nov 6, 2024
Merged via the queue into carbon-design-system:main with commit 32aa2b2 Nov 6, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Carousel code coverage
3 participants