refactor: style specific sticky columns in carbon row #6351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6351 +/- ##
==========================================
+ Coverage 79.58% 79.61% +0.02%
==========================================
Files 394 394
Lines 12861 12861
Branches 4266 4266
==========================================
+ Hits 10236 10239 +3
+ Misses 2625 2622 -3
|
elycheea
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Ooh, the conflict of sticky columns with an AI row is kind of interesting.
| With sticky background | Matching first column background |
|---|---|
 |
 |
Documentation for our designers ... without the background, we run into this unfortunate scenario when using sticky columns:
That aside, I do think this fix resolves most cases.
There is a small fix I think we still need to make on the frozen column header (and when hovered).
| Frozen header | Frozen header with hover |
|---|---|
 |
 |
elycheea
reviewed
Nov 12, 2024
elycheea
approved these changes
Nov 13, 2024
sangeethababu9223
approved these changes
Nov 18, 2024
Merged
via the queue into
carbon-design-system:main
with commit Nov 18, 2024
f4b1706
30 of 31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6268
this pr refactors #4458, to apply backgrounds only on sticky elements, thus fixing ai-lable variants of datagrid
note: there is still a design conflict if we wanna use ai-lable with sticky column.
What did you change?
packages/ibm-products-styles/src/components/Datagrid/styles/_datagrid.scss
How did you test and verify your work?
storybook