Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datagrid): adds radio filter #5877

Conversation

AlexanderMelox
Copy link
Contributor

Closes #5742

This PR adds a new filter type to Radio buttons. The radio button will now search for the exactText react-table function when filtering rather than using .includes()

What did you change?

  • packages/ibm-products/src/components/Datagrid/useFiltering.ts
  • packages/ibm-products/src/components/Datagrid/utils/FilteringUsage.js

How did you test and verify your work?

Ran the same scenario as the issue and got it to work.

Screen.Recording.2024-08-15.at.1.48.20.PM.mov

@AlexanderMelox AlexanderMelox requested a review from a team as a code owner August 15, 2024 17:49
@AlexanderMelox AlexanderMelox requested review from ariellalgilmore and devadula-nandan and removed request for a team August 15, 2024 17:49
Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 83fef74
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66be3f9040b89200087cfc7b
😎 Deploy Preview https://deploy-preview-5877--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@devadula-nandan devadula-nandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewgallo matthewgallo added this pull request to the merge queue Aug 19, 2024
Merged via the queue into carbon-design-system:main with commit 12667e8 Aug 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataGrid filter of type Radio doesn't filter properly
3 participants