Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Datagrid): column custimisation search filter truncation #5850

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

devadula-nandan
Copy link
Contributor

Closes #5834

fixed string filtering logic

What did you change?

packages/ibm-products/src/components/Datagrid/Datagrid/addons/CustomizeColumns/DraggableItemsList.js

How did you test and verify your work?

storybook

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 4958018
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66ba193795449b000876f64a
😎 Deploy Preview https://deploy-preview-5850--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devadula-nandan devadula-nandan marked this pull request as ready for review August 12, 2024 14:16
@devadula-nandan devadula-nandan requested a review from a team as a code owner August 12, 2024 14:16
@devadula-nandan devadula-nandan requested review from sangeethababu9223 and amal-k-joy and removed request for a team August 12, 2024 14:16
@szinta szinta self-requested a review August 13, 2024 05:42
Copy link
Contributor

@szinta szinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AlexanderMelox AlexanderMelox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in storybook 🚀

@AlexanderMelox AlexanderMelox added this pull request to the merge queue Aug 13, 2024
Merged via the queue into carbon-design-system:main with commit b639fe2 Aug 13, 2024
20 checks passed
@devadula-nandan devadula-nandan deleted the 5834 branch September 17, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants