Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Conditionbuilder): typescript migration #5841

Merged
merged 8 commits into from
Aug 20, 2024
Merged

chore(Conditionbuilder): typescript migration #5841

merged 8 commits into from
Aug 20, 2024

Conversation

amal-k-joy
Copy link
Contributor

Closes #5670

Typescript migration for condition builder

What did you change?


1. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilder.types.ts
2. packages/ibm-products/src/components/ConditionBuilder/ConditionBlock/ConditionBlock.tsx
3. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilder.tsx
4. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderActions/ConditionBuilderActions.tsx
5. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderAdd/ConditionBuilderAdd.tsx
6. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderButton/ConditionBuilderButton.tsx
7. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderConnector/ConditionConnector.tsx
8. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderContent/ConditionBuilderContent.tsx
9. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderContext/ConditionBuilderProvider.tsx
10. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItem.tsx
11. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemDate/ConditionBuilderItemDate.tsx
12. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemNumber/ConditionBuilderItemNumber.tsx
13. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemOption/ItemOption.tsx
14. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemOption/ItemOptionForValueField.tsx
15. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemText/ConditionBuilderItemText.tsx
16. packages/ibm-products/src/components/ConditionBuilder/ConditionBuilderItem/ConditionBuilderItemTime/ConditionBuilderItemTime.tsx
17. packages/ibm-products/src/components/ConditionBuilder/ConditionGroupBuilder/ConditionGroupBuilder.tsx
18. packages/ibm-products/src/components/ConditionBuilder/ConditionPreview/ConditionPreview.tsx

How did you test and verify your work?

TS error and storybook

@amal-k-joy amal-k-joy requested a review from a team as a code owner August 9, 2024 08:49
@amal-k-joy amal-k-joy requested review from AlexanderMelox and annawen1 and removed request for a team August 9, 2024 08:49
@netlify Netlify
Copy link

netlify bot commented Aug 9, 2024 •
edited
Loading

✅ Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 3f7be14
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66c2f03677a265000806007c
😎 Deploy Preview https://deploy-preview-5841--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amal-k-joy amal-k-joy requested a review from makafsal August 9, 2024 08:49
@amal-k-joy amal-k-joy changed the title Conditionbuilder typescript chore(Conditionbuilder): typescript migration Aug 9, 2024
davidmenendez
davidmenendez requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed with @AlexanderMelox

@amal-k-joy amal-k-joy added this pull request to the merge queue Aug 20, 2024
Merged via the queue into carbon-design-system:main with commit 4d2e6e8 Aug 20, 2024
19 of 21 checks passed
@amal-k-joy amal-k-joy deleted the conditionbuilder_typescript branch August 20, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderMelox AlexanderMelox AlexanderMelox approved these changes

@davidmenendez davidmenendez davidmenendez approved these changes

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-products-reviewers

@makafsal makafsal Awaiting requested review from makafsal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Typescript types to ConditionBuilder
3 participants
@amal-k-joy @davidmenendez @AlexanderMelox