fix: condition builder style issues

carbon-design-system · Jan 17, 2025 · fa5a8ba · fa5a8ba
1 parent df21099
commit fa5a8ba
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/packages/ibm-products-styles/src/components/ConditionBuilder/_condition-builder.scss b/packages/ibm-products-styles/src/components/ConditionBuilder/_condition-builder.scss
@@ -24,12 +24,6 @@
 // The block part of our conventional BEM class names (blockClass__E--M).
 $block-class: #{c4p-settings.$pkg-prefix}--condition-builder;
 
-// .#{$block-class} {
-//   // TODO: Styles.
-// }
-.#{$block-class} {
-  padding: $spacing-06;
-}
 .#{$block-class}__condition-builder__group {
   display: flex;
 }
@@ -52,6 +46,9 @@ $block-class: #{c4p-settings.$pkg-prefix}--condition-builder;
   width: fit-content;
   flex-direction: row;
 }
+// .#{$block-class}__condition-block:hover button:not([data-name="connectorField"]) {
+//  background-color: red;
+// }
 .#{$block-class}__content-container {
   display: flex;
   flex-direction: column;

diff --git a/...ditionBuilder/ConditionBuilderItem/ConditionBuilderItemOption/ItemOptionForValueField.tsx b/...ditionBuilder/ConditionBuilderItem/ConditionBuilderItemOption/ItemOptionForValueField.tsx
@@ -177,11 +177,9 @@ export const ItemOptionForValueField = ({
 
       {multiSelectable && (
         <div className={`${blockClass}__multiselectSelectionStatusContainer`}>
-          <h4>
-            <label>
-              {selection.length}/{allOptions.length} Selected
-            </label>
-          </h4>
+          <label>
+            {selection.length}/{allOptions.length} Selected
+          </label>
           <Button
             kind={'ghost'}
             size={'sm'}

diff --git a/packages/ibm-products/src/components/ConditionBuilder/_storybook-styles.scss b/packages/ibm-products/src/components/ConditionBuilder/_storybook-styles.scss
@@ -3,8 +3,13 @@
 //
 // This source code is licensed under the Apache-2.0 license found in the
 // LICENSE file in the root directory of this source tree.
-//
 
-@forward '../../../../ibm-products-styles/src/global/styles/project-settings';
+@use '@carbon/styles/scss/spacing' as *;
+@use 'ALIAS_STORY_STYLE_CONFIG' as c4p-settings;
+
+// The block part of our conventional BEM class names (blockClass__E--M).
+$block-class: #{c4p-settings.$pkg-prefix}--condition-builder;
 
-// TODO: add any additional styles used by ConditionBuilder.stories.js
+.#{$block-class} {
+  padding: $spacing-06;
+}