Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch font-loading to prefetch. Add font weight option #84

Merged
merged 2 commits into from
May 20, 2019

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented May 20, 2019

Closes #48

In this PR we switch to pre-fetching the google fonts to improve font-loading performance and also to offer weights other than those provided by the @carbon/type package.

To that end, this PR also also allows devs to configure additionalFontWeights other than the defaults as a theme option:

// gatsby-config.js
__experimentalThemes: [
    {
      resolve: 'gatsby-theme-carbon',
      options: {
		// will get added to default [300, 400, 600]
        additionalFontWeights: [200]
      },
    },
  ],

@vercel
Copy link

vercel bot commented May 20, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-vpicone-arrow-fix.carbon-design-system.now.sh

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 😍

@vpicone vpicone merged commit 38564d1 into carbon-design-system:master May 20, 2019
@vpicone vpicone deleted the arrow-fix branch May 20, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anchor link arrow - not pulling in correct font (Plex)
2 participants