fix: article card type style and caption spacing #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alisonjoseph
commented
Aug 22, 2019
•
- type size broke on article cards w/ latest Carbon - fixed
- updates spacing for captions below video
- token color change broke anchor link color - fixed ref Anchor links should be same color as intro text and needs more spacing above anchor links #369
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-alisonjoseph-font-size.carbon-design-system.now.sh |
emyarod
approved these changes
Aug 23, 2019
| [class^='Video-module--video'] + .#{$prefix}--caption { | ||
| margin-top: -$spacing-08; | ||
| div[class^='Video-module--video'] + .#{$prefix}--caption { | ||
| margin-top: -4rem; |
There was a problem hiding this comment.
just wondering, we don't have a token for this?
There was a problem hiding this comment.
Good call, I can change to $layout-05 we just don't have a spacing token that goes up to 4rem
There was a problem hiding this comment.
or maybe the mini-units mixin? either way is fine imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.