-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ArtDirection component #294
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-vpicone-artdirection.carbon-design-system.now.sh |
Not sure about the name "ArtDirection", but otherwise love the simplicity here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! so are we only supporting a max of 3 different sizes to start?
@emyarod Yeah, otherwise you might end up duplicating the middle one to hit two media queries or something silly like that. |
If someone puts only two images the first will show at mobile, and the second at tablet and above, correct? |
@alisonjoseph art direction is the actual name for the thing we're doing here. I considered more vague names (e.g. Image, Picture, ImageComponent, Images, ResponsiveImages), but they all imply that there is something other than art direction happening. |
@alisonjoseph yeah that's correct. I updated the documentation to explain more clearly:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I wish that the name ArtDirection made it more clear what it did but I cant think of anything better, I agree that it's better than the other more vague name examples you gave, @vpicone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought I left an approval instead of a comment! I'm fine with the art direction name since it's the term for the problem we are solving here
No description provided.