Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next prev accordion #289

Merged
merged 3 commits into from
Jul 30, 2019
Merged

Next prev accordion #289

merged 3 commits into from
Jul 30, 2019

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Jul 30, 2019 •
edited by alisonjoseph
Loading

closes #286
closes #287

  • removes gutter for accordion
  • adjusts code snippet to align with 8 col row components
  • uses carbon--gray-90 for next-prev. There is no theme token to represent this value with the white theme.

@vpicone vpicone requested a review from alisonjoseph July 30, 2019 17:27
@vercel
Copy link

vercel bot commented Jul 30, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-vpicone-next-prev-accordion.carbon-design-system.now.sh

@vpicone vpicone requested a review from abbeyhrt July 30, 2019 17:27
alisonjoseph
alisonjoseph approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending design approval!!

@alisonjoseph alisonjoseph requested a review from jeanservaas July 30, 2019 17:45
@vpicone
Copy link
Contributor Author

vpicone commented Jul 30, 2019

@jeanservaas gave the okay!

@vpicone vpicone merged commit e169ae7 into carbon-design-system:master Jul 30, 2019
@vpicone vpicone deleted the next-prev-accordion branch July 30, 2019 20:49
@jeanservaas
Copy link
Contributor

gave vince a verbal on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@jeanservaas jeanservaas Awaiting requested review from jeanservaas

Assignees
No one assigned
Labels
status: visual review 🔍
Projects
None yet
Milestone
No milestone
4 participants
@vpicone @jeanservaas @alisonjoseph @abbeyhrt