-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: V11 migration for gatsby-theme #1209
Conversation
* fix: grid alignment at max breakpoint * fix: update to 424px because math * fix: grid at large xlg breakpoint
* Update v2-migration.mdx * update docs
Bumps [semver-regex](https://github.com/sindresorhus/semver-regex) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/sindresorhus/semver-regex/releases) - [Commits](https://github.com/sindresorhus/semver-regex/commits) --- updated-dependencies: - dependency-name: semver-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [postcss](https://github.com/postcss/postcss) from 7.0.35 to 7.0.36. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@7.0.35...7.0.36) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [engine.io](https://github.com/socketio/engine.io) from 4.1.1 to 4.1.2. - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](https://github.com/socketio/engine.io/blob/4.1.2/CHANGELOG.md) - [Commits](socketio/engine.io@4.1.1...4.1.2) --- updated-dependencies: - dependency-name: engine.io dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I've seen people trying to put too much into the description. I think it is a sane guidance to limit the content to one or two short sentences. Co-authored-by: Alessandra Davila <aledavila@ibm.com> Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.4 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.4...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com>
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/8dZG6wuuWcJjNXkp3ZrNLiJ8ibtR |
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.29 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.29...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [trim-off-newlines](https://github.com/stevemao/trim-off-newlines) from 1.0.1 to 1.0.3. - [Release notes](https://github.com/stevemao/trim-off-newlines/releases) - [Commits](stevemao/trim-off-newlines@v1.0.1...v1.0.3) --- updated-dependencies: - dependency-name: trim-off-newlines dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holy cow.. this is incredible work. Thank you @aledavila and @jnm2377 for doing this. Two things came to mind as I was reviewing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Just had a couple of quick questions/comments.
[Mozilla Developer Network’s documentation](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Complementary_role#Labeling_landmarks) | ||
for more information. Props for accessibility labels are described in the | ||
[Props section](#props) below. | ||
Mozilla Developer Network’s documentation for more information. Props for accessibility labels are described in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the links intended to be removed here or was it a temporary thing while doing the migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshblack So the v11 inline notifications don't allow for links inside of them anymore for accessibility issues. I'm not sure what we should do in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aledavila ActionableNotification
can be used, it accepts an inline
prop.
@@ -25,12 +25,12 @@ for you to share your component with other theme consumers down the line. | |||
Every Sass file in your project automatically has access to the the following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you able to "auto-import" styles with Sass modules to mirror how the theme currently works?
packages/gatsby-theme-carbon/src/components/ArticleCard/article-card.scss
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! The deploy preview doesn't seem to have any problems besides the ones surfaced in comments above. Below is just a few items I'm curious about.
packages/gatsby-theme-carbon/src/styles/internal/_carbon-components.scss
Outdated
Show resolved
Hide resolved
…arbon into v11-migration
* breaking: upgrade gatsby dependencies to v4 * chore: release 3.0.0-next.0 * chore(theme): update to 4.4 (#1203) * fix: medium post image aspect ratio closes #1176 (#1185) * fix: medium post image aspect ratio closes #1176 * fix: only add background to the bottom half of article cards * fix: grid alignment at max breakpoint (#1181) * fix: grid alignment at max breakpoint * fix: update to 424px because math * fix: grid at large xlg breakpoint * chore: release 2.1.5 * Update CODEOWNERS (#1190) * Update v2-migration.mdx (#1193) * Update v2-migration.mdx * update docs * Update Switcher.js (#1192) * chore: release 2.1.6 * build(deps): bump semver-regex from 3.1.2 to 3.1.3 (#1196) Bumps [semver-regex](https://github.com/sindresorhus/semver-regex) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/sindresorhus/semver-regex/releases) - [Commits](https://github.com/sindresorhus/semver-regex/commits) --- updated-dependencies: - dependency-name: semver-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: aside docs (#1202) * chore(theme): update to 4.4 Co-authored-by: Vince Picone <vpicone@gmail.com> Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com> Co-authored-by: Vince Picone <vp@vincepic.one> Co-authored-by: Ale Davila <aledavila@ibm.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: release 3.0.0-next.1 * chore(next): update with latest from main (#1226) * feat: V11 migration for gatsby-theme (#1209) * fix: medium post image aspect ratio closes #1176 (#1185) * fix: medium post image aspect ratio closes #1176 * fix: only add background to the bottom half of article cards * fix: grid alignment at max breakpoint (#1181) * fix: grid alignment at max breakpoint * fix: update to 424px because math * fix: grid at large xlg breakpoint * chore: release 2.1.5 * Update CODEOWNERS (#1190) * Update v2-migration.mdx (#1193) * Update v2-migration.mdx * update docs * Update Switcher.js (#1192) * chore: release 2.1.6 * build(deps): bump semver-regex from 3.1.2 to 3.1.3 (#1196) Bumps [semver-regex](https://github.com/sindresorhus/semver-regex) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/sindresorhus/semver-regex/releases) - [Commits](https://github.com/sindresorhus/semver-regex/commits) --- updated-dependencies: - dependency-name: semver-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: aside docs (#1202) * feat(switcher): add carbon for ibm products remove ix (#1205) * chore: release 2.2.0 * build(deps): bump postcss from 7.0.35 to 7.0.36 (#1206) Bumps [postcss](https://github.com/postcss/postcss) from 7.0.35 to 7.0.36. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@7.0.35...7.0.36) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump engine.io from 4.1.1 to 4.1.2 (#1207) Bumps [engine.io](https://github.com/socketio/engine.io) from 4.1.1 to 4.1.2. - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](https://github.com/socketio/engine.io/blob/4.1.2/CHANGELOG.md) - [Commits](socketio/engine.io@4.1.1...4.1.2) --- updated-dependencies: - dependency-name: engine.io dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(page-description): update PageDescription docs (#1195) I've seen people trying to put too much into the description. I think it is a sane guidance to limit the content to one or two short sentences. Co-authored-by: Alessandra Davila <aledavila@ibm.com> Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> * build(deps): bump follow-redirects from 1.14.4 to 1.14.7 (#1208) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.4 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.4...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> * feat: migrate to v11 * feat: migrate to v11 yarn lock * feat: update component prefix * feat: update imports * feat: icon size prop/imports * fix: try to add styles * build(deps): bump nanoid from 3.1.29 to 3.2.0 (#1210) Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.29 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.29...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump trim-off-newlines from 1.0.1 to 1.0.3 (#1213) Bumps [trim-off-newlines](https://github.com/stevemao/trim-off-newlines) from 1.0.1 to 1.0.3. - [Release notes](https://github.com/stevemao/trim-off-newlines/releases) - [Commits](stevemao/trim-off-newlines@v1.0.1...v1.0.3) --- updated-dependencies: - dependency-name: trim-off-newlines dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: update the references to the new homepage (#1212) Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> * feat: migrate styles to v11 * feat(expressive-list): creates the expressive content only list (#1197) * feat(expressive-list): creates the expressive content only list * feat(expressive-list): add new props * feat(expressive-list): add pictogram variant * chore(expressive-list): clean up * chore(expressive-list): fix expressive list styles * docs(expressive-list): fix expressive list docs * docs(expressive-list): update expressive list docs * chore(expressive-list): add title type examples * docs(expressive-list): add title examples to pictogram Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com> * Update CONTRIBUTING.md (#1215) * feat: import all styles from react * feat: add additional aspect ratios for do dont (#1216) * feat: add additional aspect ratios for do dont * chore: add examples for aspect ratios * feat(grid): update grid in theme * build(deps): bump follow-redirects from 1.14.7 to 1.14.8 (#1222) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: do dont component updates (#1220) * fix: do dont component updates * fix: spelling * fix: add color token * feat: new config option to add default mdx layouts (#1214) * feat: new config option to add default mdx layouts * feat: add documentation Co-authored-by: Stefan Zecevic <szecevic@ibm.com> Co-authored-by: Alessandra Davila <adavila91@gmail.com> * feat(expressive-list-container): adds expressive list container component (#1198) * feat(expressive-list-container): adds expressive list container component * chore(expressive-list-container): change children prop type * docs(expressive-list-container): add disclaimer * Update packages/example/src/pages/components/ExpressiveListContainer.mdx Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com> * build(deps): bump simple-get from 3.1.0 to 3.1.1 (#1223) Bumps [simple-get](https://github.com/feross/simple-get) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/feross/simple-get/releases) - [Commits](feross/simple-get@v3.1.0...v3.1.1) --- updated-dependencies: - dependency-name: simple-get dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com> * chore: release 2.3.0 * feat(grid): add 12 grid * fix: fleex grid 12 col * feat: migrate notification and remove comments * fix: tile components and aspect ratio * fix: temp comment out abbr export * fix(header): update header svg colors * chore: update package * chore: update yarn lock Co-authored-by: Vince Picone <vpicone@gmail.com> Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com> Co-authored-by: Vince Picone <vp@vincepic.one> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stephane Rodet <s@rodet.org> Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> Co-authored-by: Josefina Mancilla <josefinanoemi4@gmail.com> Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com> Co-authored-by: Stefan Zecevic <stefan@zecevic.xyz> Co-authored-by: Stefan Zecevic <szecevic@ibm.com> * chore: release 3.0.0-next.2 * chore: release 3.0.0-next.2 * chore(project): update carbon deps (#1228) * chore: release 3.0.0-next.3 * Remove all usages of carbon components on `next` (#1229) * fix(v11): remove all usages of carbon-components * chore(gatsby): update to v4.9.2 * fix(inlinenotification): re-enable inline links (#1231) * chore: release 3.0.0-next.4 * chore(project): update to carbon 10.56.0, correct style import order (#1234) * chore(project): update to carbon 10.55.2, correct style import order * fix(feedbackdialog): correct tokens to fix style issues * fix(feedbackdialog): style fixes for v11 * chore(project): update carbon deps to 10.56.0 * fix(components): use individual imports instead of central entrypoint * chore: release 3.0.0-next.5 * fix(overlays): correct z-index for backtotop and launch buttons * chore: release 3.0.0-next.6 * fix(codeblock): use correct font-family * chore: release 3.0.0-next.7 * chore(project): update carbon dependencies, related fixes * chore: release 3.0.0-next.8 * chore(project): update carbon to v11, related import/usage fixes * chore: release 3.0.0-next.9 * feat(type): update carbon deps, ensure type-classes are emitted with proper prefix * chore: release 3.0.0-next.10 * fix(grid): add _grid.scss and move over flex grid for precedence (#1242) * chore: release 3.0.0-next.11 * fix(markdown): ensure links within lists do not have padding (#1246) * fix(markdown): ensure links within lists do not have uneccessary padding and render inline * fix(list): update prefix * chore: release 3.0.0-next.12 * chore(project): update changelog * feat(gtc): upgrade to v4 Gatsby, v11 Carbon, and associated docs (#1261) * feat(gtc): upgrade to v4 Gatsby, v11 Carbon, and associated docs * Update packages/example/src/pages/guides/v3-migration.mdx Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com> * fix(icon): dropped the file in the right folder * docs(migration): add icons migration info * feat(gtc): split docs into two sets of migrations, updated deps round 1 * feat(gtc): updated the rest of the gatsby deps * chore(gtc): updated carbon deps * fix(util): removed layout Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com> Co-authored-by: Taylor Jones <taylor.jones826@gmail.com> * chore(deps): update carbon deps * chore: release 3.0.0-next.13 Co-authored-by: Vince Picone <vp@vincepic.one> Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> Co-authored-by: Vince Picone <vpicone@gmail.com> Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com> Co-authored-by: Ale Davila <aledavila@ibm.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Scott Strubberg <sstrubberg@us.ibm.com> Co-authored-by: Stephane Rodet <s@rodet.org> Co-authored-by: Josefina Mancilla <josefinanoemi4@gmail.com> Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com> Co-authored-by: Stefan Zecevic <stefan@zecevic.xyz> Co-authored-by: Stefan Zecevic <szecevic@ibm.com> Co-authored-by: DAK <40970507+dakahn@users.noreply.github.com>
v11 migration start