Spacing issues in the theme.

[mjabbink]

Horizontal spacing between Feature cards should be minimum of 32px and we also use 64px

FOr Artical cards the horzontal spacing shoulf be 16px:

[mjabbink]

related to the issues in #613

[mjabbink]

@sadekbazaraa

[sadekbazaraa]

@mjabbink in general, we always have 32px between elements vertically. The cards above have 16px space on the right side only so we can keep the type on the columns, otherwise we'd use the cards that butt up against each other. Either way, I think we should always maintain our consistent 32px minimum spacing between items vertically whether we're using touching cards or cards that have the 16px to the right. This is the way it's always been in our original sketch files.

[sadekbazaraa]

@mjabbink also worth noting in the screenshot above is that the spacing is globally applied to the top of these cards, this is what also gives the 32px space between the intro paragraph and the first set of cards. If we go adjusting these cards to have 16px on top now, we'll start breaking other things in the process.

[mjabbink]

I thought so but the current situation is not 32px or 16px in many places. BC and even Gatsby demo site has some other pixel amounts there.

https://gatsby-theme-carbon.now.sh/components/ArticleCard/#example

https://gatsby-theme-carbon.now.sh/components/FeatureCard

BC:

https://www.ibm.com/brand/systems/#additional-systems

this seems wrong too. Seems like the horizontal spacing should be 16px here too.
https://www.ibm.com/brand/expression

[mjabbink]

Seems like the good of cards should not be turned into rows but I’m not wed to this. If this is how it’s been then we can leave the 32px between the 16px.

[sadekbazaraa]

@mjabbink I think something happened with spacing in multiple places with the last Gatsby update which was recent. I can see all the subtle errors in the links you posted above. Not sure what happened along the way?

The Systems page on Brand Center should be the way we've outlined it here: https://github.ibm.com/brand/events/issues/37

[mjabbink]

@sadekbazaraa I reckon I’m OK with 32 with article cards. I just gotta get my head around the different spacing between horizontal and vertical. @sstrubberg

[vpicone]

@sadekbazaraa since the spacing overhaul last year, our default vertical space has been 24px. We created an exception for the DoDont for example so that the vertical and horizontal were both 32px.