Skip to content

Commit

Permalink
fix: use whitespace to ensure smart quotes get replaced in text (#610)
Browse files Browse the repository at this point in the history
* fix: use whitespace to ensure smart quotes get replaced in text content closes #600

* fix: update all dumb quotes in source
  • Loading branch information
vpicone authored Dec 13, 2019
1 parent 068fec5 commit 8a75d38
Show file tree
Hide file tree
Showing 25 changed files with 142 additions and 139 deletions.
4 changes: 2 additions & 2 deletions .github/CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ This is a place to ask questions, work through any challenges, and share ideas a

### General

Communication through any of Carbon's channels (GitHub, emails, Twitter, Slack) must be constructive and never resort to personal attacks, trolling, public or private harassment, insults, or other unprofessional conduct.
Communication through any of Carbons channels (GitHub, emails, Twitter, Slack) must be constructive and never resort to personal attacks, trolling, public or private harassment, insults, or other unprofessional conduct.

We promise to extend courtesy and respect to everyone involved in this project, regardless of gender, gender identity, sexual orientation, disability, age, race, ethnicity, religion, or level of experience. We expect anyone contributing to Carbon to do the same.

Expand All @@ -21,7 +21,7 @@ If you are subjected to or witness unacceptable behavior, or have any other conc
### Slack

1. Please, no `@here` or `@channel` unless it is a bug that is **breaking production code.** We have communities in many different time zones, and we would hate to disrupt someone not at the office.
2. There's no need to notify the Carbon team that you have made an issue in Carbon's GitHub repositories. We check these several times a day, so we promise we'll address your issue as soon as we can.
2. Theres no need to notify the Carbon team that you have made an issue in Carbons GitHub repositories. We check these several times a day, so we promise well address your issue as soon as we can.
3. Reserve direct messages for sensitive discussions, such as privacy, legal, or HR reasons. Otherwise, we encourage posting in public channels so people with the same questions can benefit.
4. If you have a pressing bug fix, it is best to make a PR directly to get your issues addressed.
5. `#carbon-gatsby-theme`: This channel is for questions about the Carbon Gatsby theme only. It is not the place to ask general coding questions. Instead, use a dev community like [StackOverflow](https://stackoverflow.com/).
Expand Down
8 changes: 4 additions & 4 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ You can request a new feature by submitting an issue to this repo. Proposed feat

## Doc fixes

If you want to help improve the docs, it's a good idea to let others know what you're working on to minimize duplication of effort. Comment on an issue to let others know what you're working on, or create a new issue if your work doesn't fit within the scope of any of the existing doc fix projects.
If you want to help improve the docs, its a good idea to let others know what youre working on to minimize duplication of effort. Comment on an issue to let others know what youre working on, or create a new issue if your work doesnt fit within the scope of any of the existing doc fix projects.

**Please see the submission guidelines below**.

Expand Down Expand Up @@ -61,11 +61,11 @@ If you want to help improve the docs, it's a good idea to let others know what y

Before you submit your issue, search the repository. Maybe your question was already answered.

If your issue appears to be a bug, and hasn't been reported, open a new issue. Help us to maximize the effort we can spend fixing issues and adding new features, by not reporting duplicate issues.
If your issue appears to be a bug, and hasnt been reported, open a new issue. Help us to maximize the effort we can spend fixing issues and adding new features, by not reporting duplicate issues.

### Submitting a pull request

1. Search this repository for an open or closed pull request that relates to your submission. You don't want to duplicate effort.
1. Search this repository for an open or closed pull request that relates to your submission. You dont want to duplicate effort.

2. Pull the latest master branch from `upstream`:

Expand Down Expand Up @@ -107,4 +107,4 @@ If your issue appears to be a bug, and hasn't been reported, open a new issue. H

Once all revisions to your pull request are complete, a maintainer will squash and merge your commits for you.

**That's it! Thank you for your contribution!**
**Thats it! Thank you for your contribution!**
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<!-- Feel free to remove sections that aren't relevant.
<!-- Feel free to remove sections that arent relevant.
## Title line template: [Title]: Brief description
-->

## Detailed description

> Describe in detail the issue you're having.
> Describe in detail the issue youre having.
> Is this a feature request (new component, new icon), a bug, or a general issue?
Expand All @@ -23,7 +23,7 @@ Please try to re-create the issue using our Codesandbox template available here:
- React https://codesandbox.io/s/x2mjypo6pp - Vue https://codesandbox.io/s/5zk452o9jp
This helps reduce the issue to an isolated case that helps us out when debugging.
If you're able to reproduce using the codesandbox link above, please include the
If youre able to reproduce using the codesandbox link above, please include the
link in addition to the steps to reproduce. Thanks so much!
-->

Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/accessibility-issue--.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ labels: 'type: a11y'
assignees: ''
---

<!-- Feel free to remove sections that aren't relevant.
<!-- Feel free to remove sections that arent relevant.
## Title line template: [Title]: Brief description
Expand Down
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,20 @@
name: "Bug report \U0001F41B"
about: Create a report to help us improve
title: ''
projects: "carbon-design-system/27"
projects: 'carbon-design-system/27'
labels: 'type: bug 🐛'
assignees: ''
---

<!-- Feel free to remove sections that aren't relevant.
<!-- Feel free to remove sections that arent relevant.
## Title line template: [Title]: Brief description
-->

## Detailed description

> Describe in detail the issue you're having.
> Describe in detail the issue youre having.
> What did you expect to happen? What happened instead? What would you like to see changed?
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ This should not be a full list of functionality; the Carbon team will work with

Do you want this work within a specific time period? Is it related to an upcoming release?

_NB: The Carbon team will try to work with your timeline, but it's not guaranteed. The earlier you make a request in advance of a desired delivery date, the better!_
_NB: The Carbon team will try to work with your timeline, but its not guaranteed. The earlier you make a request in advance of a desired delivery date, the better!_

### Available extra resources

Expand Down
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/question.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@ assignees: ''
Hi there! 👋 Hope everything is going okay using projects from the Carbon Design
System. It looks like you might have a question about our work, so we wanted to
share a couple resources that you could use if you haven't tried them yet 🙂.
share a couple resources that you could use if you havent tried them yet 🙂.
If you're an IBMer, we have a couple of Slack channels available across all IBM
If youre an IBMer, we have a couple of Slack channels available across all IBM
Workspaces:
- #carbon-design-system for questions about the Design System
- #carbon-components for questions about component styles
- #carbon-react for questions about our React components
If these resources don't work out, help us out by filling out a couple of
If these resources dont work out, help us out by filling out a couple of
details below!
-->
Expand Down
8 changes: 4 additions & 4 deletions packages/example/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,21 @@

> Gatsby has implemented a new feature called [themes](https://www.gatsbyjs.org/docs/themes/). Themes encapsulate all of the configuration and implementation details of Gatsby websites. This is a starter-kit (boilerplate) that has a dependancy on the `gatsby-theme-carbon` package. It includes some sample content in the `src/pages` directory.
## What's included?
## Whats included?

- Carbon Elements and Carbon React
- [Emotion](https://emotion.sh) for React component styling
- [gatsby-mdx](https://gatsby-mdx.netlify.com/) with brand new markdown components

## How do I use it?

`gatsby-theme-carbon` at it's core relies on [mdx](https://mdxjs.com/) for page creation. Check out the `src/pages` directory for some examples for using mdx.
`gatsby-theme-carbon` at its core relies on [mdx](https://mdxjs.com/) for page creation. Check out the `src/pages` directory for some examples for using mdx.

A key feature of Gatsby themes is component shadowing. By simply placing a component into the `src/gatsby-theme-carbon/components` location, you can override components used by the theme. You can read more about component shadowing [here](https://www.gatsbyjs.org/docs/themes/api-reference#component-shadowing).

You're also free to make your own components and use them in your MDX pages.
Youre also free to make your own components and use them in your MDX pages.

## What's Next?
## Whats Next?

- Migrating reusable MDX components
- Parameters to configure Carbon theme
2 changes: 1 addition & 1 deletion packages/example/src/pages/components/Aside.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ It should only be used within a `<Column>` component with specific parameters. `

<InlineNotification kind="warning">

**Warning:** If you use more than one `<Aside>` component on a single page, you need to provide an accessibility label so that someone using assistive technology can quickly understand the purpose of the landmark. See [Mozilla Developer Network's documentation](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Complementary_role#Labeling_landmarks) for more information. Props for accessibility labels are described in the [Props section](#props) below.
**Warning:** If you use more than one `<Aside>` component on a single page, you need to provide an accessibility label so that someone using assistive technology can quickly understand the purpose of the landmark. See [Mozilla Developer Networks documentation](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Complementary_role#Labeling_landmarks) for more information. Props for accessibility labels are described in the [Props section](#props) below.

</InlineNotification>

Expand Down
8 changes: 4 additions & 4 deletions packages/example/src/pages/components/Caption.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ The `<Caption>` component is typically used below images or videos. They will de
<Video src="/videos/hero-video.mp4" poster="/images/poster.png" />

<Caption>
This is a regular caption. It will attempt to respond to it's container
This is a regular caption. It will attempt to respond to its container
element appropriately.
</Caption>

Expand All @@ -25,7 +25,7 @@ The `<Caption>` component is typically used below images or videos. They will de
![Colors](images/colors.png)

<Caption fullWidth>
This is a full width caption. With this prop, the caption's width will be 100%
This is a full width caption. With this prop, the captions width will be 100%
so it will fill its container.
</Caption>

Expand All @@ -35,7 +35,7 @@ The `<Caption>` component is typically used below images or videos. They will de

```jsx path=components/Caption/Caption.js src= https://github.com/carbon-design-system/gatsby-theme-carbon/tree/master/packages/gatsby-theme-carbon/src/components/Caption
<Caption>
This is a regular caption. It will attempt to respond to it's container
This is a regular caption. It will attempt to respond to its container
element appropriately.
</Caption>
```
Expand All @@ -44,7 +44,7 @@ The `<Caption>` component is typically used below images or videos. They will de

```jsx path=components/Caption/Caption.js src= https://github.com/carbon-design-system/gatsby-theme-carbon/tree/master/packages/gatsby-theme-carbon/src/components/Caption
<Caption fullWidth>
This is a full width caption. With this prop, the caption's width will be 100%
This is a full width caption. With this prop, the captions width will be 100%
so it will fill its container.
</Caption>
```
Expand Down
6 changes: 3 additions & 3 deletions packages/example/src/pages/components/Grid.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ To learn more about the grid is built, you can read the docs in the [Carbon](htt

<PageDescription>

The `<Grid>` component is a wrapper that adds the `bx--grid` class to a wrapper div. **You won't need this** when adding components to `.mdx` pages as this is already built into the template.
The `<Grid>` component is a wrapper that adds the `bx--grid` class to a wrapper div. **You wont need this** when adding components to `.mdx` pages as this is already built into the template.

</PageDescription>

Expand Down Expand Up @@ -222,8 +222,8 @@ The `<Column>` component is used to define column widths for your content, you c
| colSm | number | | | Specify the col width at small breakpoint |
| colMd | number | | | Specify the col width at medium breakpoint |
| colLg | number | | 12 | Specify the col width at large breakpoint |
| colXl | number | | | Specify the col width at x-large breakpoint |
| colMax | number | | | Specify the col width at max breakpoint |
| colXl | number | | | Specify the col width at x-large breakpoint |
| colMax | number | | | Specify the col width at max breakpoint |
| offsetSm | number | | | Specify the col offset at small breakpoint |
| offsetMd | number | | | Specify the col offset at medium breakpoint |
| offsetLg | number | | | Specify the col offset at large breakpoint |
Expand Down
4 changes: 2 additions & 2 deletions packages/example/src/pages/components/ImageGallery.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ Click on an image to open the gallery.

## Markdown Code

You can use the ImageGallery component in markdown by nesting your images inside the ImageGallery component and using the ImageGalleryImage component to define the image's location, title, alt tag, and the columns the image on the page will span at the medium and large breakpoints. There is no gallery view for mobile so the small breakpoint is not defined.
You can use the ImageGallery component in markdown by nesting your images inside the ImageGallery component and using the ImageGalleryImage component to define the images location, title, alt tag, and the columns the image on the page will span at the medium and large breakpoints. There is no gallery view for mobile so the small breakpoint is not defined.

Here's an example of how to use the ImageGallery and the ImageGalleryImage components in markdown.
Heres an example of how to use the ImageGallery and the ImageGalleryImage components in markdown.

```markdown path=/components/ImageGallery.mdx src=https://gatsby-theme-carbon.now.sh
<ImageGallery>
Expand Down
2 changes: 1 addition & 1 deletion packages/example/src/pages/components/PageDescription.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ For most pages, we recommend starting with a `PageDescription` followed by `Anch

</PageDescription>

Please note that this component, like all MDX components, is picky about white space, the line break above and below your content is required, and if you even have an extra space on the empty lines above/below it won't render correctly.
Please note that this component, like all MDX components, is picky about white space, the line break above and below your content is required, and if you even have an extra space on the empty lines above/below it wont render correctly.

## Example

Expand Down
10 changes: 5 additions & 5 deletions packages/example/src/pages/components/Tabs.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: Usage instructions for the Tabs component

<PageDescription>

The `<Tabs>` and `<Tab>` components are used together to display and swap between content. Like all of the MDX components, you'll need to give the content you pass in a line of whitespace. When in doubt, follow the examples. Everything should be left aligned, indenting `<Tab>` will result in errors.
The `<Tabs>` and `<Tab>` components are used together to display and swap between content. Like all of the MDX components, youll need to give the content you pass in a line of whitespace. When in doubt, follow the examples. Everything should be left aligned, indenting `<Tab>` will result in errors.

</PageDescription>

Expand All @@ -15,13 +15,13 @@ The `<Tabs>` and `<Tab>` components are used together to display and swap betwee

<Tab label="Text">

The tab component can be used for a variety of content. From text, to images, to columns. If you want to have multiple columns, you'll need to use our `Row` and `Column` helpers as demonstrated in the "Two images" tab.
The tab component can be used for a variety of content. From text, to images, to columns. If you want to have multiple columns, youll need to use our `Row` and `Column` helpers as demonstrated in the "Two images" tab.

</Tab>

<Tab label="Single image">

If your content is full width, you don't need `Row` and `Column`
If your content is full width, you dont need `Row` and `Column`

![color array](images/colors.png)

Expand Down Expand Up @@ -60,7 +60,7 @@ Column two

<Tab label="Text">

The tab component can be used for a variety of content. From text, to images, to columns. If you want to have multiple columns, you'll need to use our `Row` and `Column` helpers as demonstrated in the "Two images" tab.
The tab component can be used for a variety of content. From text, to images, to columns. If you want to have multiple columns, youll need to use our `Row` and `Column` helpers as demonstrated in the "Two images" tab.

</Tab>
```
Expand All @@ -69,7 +69,7 @@ The tab component can be used for a variety of content. From text, to images, to

```jsx path=components/Tabs/Tabs.js src=https://github.com/carbon-design-system/gatsby-theme-carbon/tree/master/packages/gatsby-theme-carbon/src/components/Tabs
<Tab label="Single image">
If your content is full width, you don't need `Row` and `Column` ![color
If your content is full width, you dont need `Row` and `Column` ![color
array](images/colors.png)
</Tab>
```
Expand Down
Loading

1 comment on commit 8a75d38

@vercel
Copy link

@vercel vercel bot commented on 8a75d38 Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.