This repository was archived by the owner on Apr 26, 2019. It is now read-only.
[WIP] Big V9 PR #223
Merged
[WIP] Big V9 PR #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asudoh
reviewed
May 29, 2018
There was a problem hiding this comment.
Looks good overall 👍 except just one thing - Thank you @marijohannessen!
| @@ -31,7 +31,8 @@ class ComponentExample extends Component { | |||
| currentComponent = currentVariation; | |||
| } | |||
| if (value === 'field-02') { | |||
| if (currentVariation.includes('--')) { | |||
| if (currentVariation.includes('--') || currentVariation === 'code-snippet--inline') { | |||
| console.log(`carbon-components/html/${currentComponent}/${currentVariation}-light.html`); | |||
There was a problem hiding this comment.
Did you intend to remove this line...?
59fab2c to
f7db820
Compare
f7db820 to
68d2543
Compare
marijohannessen
added a commit
to marijohannessen/design-system-website
that referenced
this pull request
Jun 1, 2018
* wip * updates to the side nav * wip * more work on v9 * more wip * added new colors * fixed hover colors on the color page * rebased the latest v9
marijohannessen
added a commit
that referenced
this pull request
Jun 4, 2018
* Code Snippet color changes (#213) * added in common actions sections and updated content for loading and overflow * added in new syntax colors * removed duplicate * added space * added space * Carbon V9 merge (#216) * Update v9 branch with latest master (#218) * Added in User Flow and changed the internal IA (#214) * added in user flow and changed the internal IA * updated user flow and iamges * updated user flow image * fixed redirect from old route (#215) * Code Snippet color changes (#213) * added in common actions sections and updated content for loading and overflow * added in new syntax colors * removed duplicate * added space * added space * Carbon V9 merge (#216) * update v9 * Updates to Component Page (#219) * started working on adding in comps * more work on adding react links * more work on react links and field switcher * fixes from component page PR that didn't get merged in (#221) * more work on adding react links * more work on react links and field switcher * latest fixes that didnt get merged in * Merged tooltips (#202) * updated all usage images with new colors * New Tooltip variation:docs * updated content & images for style and usage tabs * Updated input component content (#222) * V9 - Update input images & color content (#225) * Updated input component content * work in progress * v9-more-content * Code snippet updates (#220) * Added in User Flow and changed the internal IA (#214) * added in user flow and changed the internal IA * updated user flow and iamges * updated user flow image * fixed redirect from old route (#215) * code snippet updates * new images (#230) * new images * removed section about filtering * removed filtering * added common actions back in * [WIP] Big V9 PR (#223) * wip * updates to the side nav * wip * more work on v9 * more wip * added new colors * fixed hover colors on the color page * rebased the latest v9 * fixed urls (#231) * Random updates (#232) * lock file * wip * image updates * switched back package.json (#233) * updated component status page (#235) * Codepens (#242) * fix: remove border-radius: 0 override for all buttons * chore: update codepen links for new components * feat(icon): update iconography page with new icons (#243) * v9 Updated images (#241) * Audit work (#238) * added in proper hover classes and hex values, usage tab gif updates * more updates * even mroe random updates :) * Fixes from audit meeting (#244) * fixed bugs from audit meeting * force update * wip * more audit work * fix(icons): add print logic for svgString (#246) * current v9 deploy * fixed icons download and rebased master * added in codepen links for danger buttons * added wahts new content * more v9 work * updated package json and whats new page * updated to latest versions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://github.ibm.com/carbon/issues/issues/705
Ref https://github.ibm.com/carbon/issues/issues/704