-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grid): make subgrid work with grid offset #9803
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: f0798d9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/616725b697e0590007f1c455 😎 Browse the preview: https://deploy-preview-9803--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: f0798d9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/616725b69572990007f25180 😎 Browse the preview: https://deploy-preview-9803--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: f0798d9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/616725b55a3c7000096febbf 😎 Browse the preview: https://deploy-preview-9803--carbon-elements.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question on my review below, but both your example story and the existing offset story look great.
proper.offset.column.reflow.mov
I pushed one small update to this - I noticed the existing stories' styles weren't being applied due to the prefix change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ref #9723 (comment)
Ensures that subgrid is supported corectly when the parent grid uses offset.
Changelog
Removed
col-end-n
rules since the existingcol-span-n
andcol-start-n
classes together are already achieving the expected stylingTesting / Reviewing
Add the test case from the discussion as a story and verify the appearance / behaviour: