Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pictogram batch and new category for August 2021 #9532

Merged

Conversation

dudley-ibm
Copy link
Contributor

Closes #

{{Closes enterprise issue #s 109, 110, 111, 113, 115, 116, 119, 121, 123, 124, 125, 126}}

Changelog

New

Issue #110
chart--quadrant-plot.svg (Data Analytics)

Issue #111
ibm--rpa.svg (Manufacturing)

Issue #113
guitar.svg (Lifestyle)

Issue #115
uruguay--sol-de-mayo.svg (Cities)

Issue #116
juice.svg (Lifestyle)

Issue #119
read-only.svg (File)

Issue #121
serverless.svg (Cloud)

Issue #123
chart--scree-plot.svg (Data Analytics)

Issue #125
universal-experiences.svg (Design)

Issue #126 all are in new category called Red Hat
build-applications-anywhere.svg (Red Hat)
cloud--native--01.svg (Red Hat)
cloud--native--02.svg (Red Hat)
cluster.svg (Red Hat)
connect--applications.svg (Red Hat)
container.svg (Red Hat)
container--microservices.svg (Red Hat)
containerized-applications.svg (Red Hat)
edge.svg (Red Hat)
hybrid--cloud--infrastructure.svg (Red Hat)
kubernetes.svg (Red Hat)
kubernetes--pod.svg (Red Hat)
manage-applications-anywhere.svg (Red Hat)
open-source.svg (Red Hat)
quantum-computing.svg (Red Hat)
red-hat--applications.svg (Red Hat)
synergy.svg (Red Hat)
virtual--server.svg (Red Hat)
virtual--storage.svg (Red Hat)

  • }}

Changed

Testing / Reviewing

{{ These pictograms should show up on both the carbondesignsystem and the IBM design language sites}}

@dudley-ibm dudley-ibm requested a review from a team as a code owner August 24, 2021 16:01
@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: cf7e207

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/612d066a7c152f0008ae973c

😎 Browse the preview: https://deploy-preview-9532--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: cf7e207

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/612d066aa9d4ca000848bc28

😎 Browse the preview: https://deploy-preview-9532--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: cf7e207

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/612d066a3a468a00088b0d3c

😎 Browse the preview: https://deploy-preview-9532--carbon-components-react.netlify.app

@sstrubberg
Copy link
Member

@dudley-ibm, try running a yarn test -u at the root of the project to update the tests.

@dudley-ibm
Copy link
Contributor Author

@sstrubberg could you clarify what the problem is? I don't always understand what's happening on the back end of these processes.

@sstrubberg
Copy link
Member

@sstrubberg could you clarify what the problem is? I don't always understand what's happening on the back end of these processes.

Sure thing. If you scroll down to the bottom of this page you'll see that one of "checks" was unsuccessful. I was trying to point you in a direction that would hopefully make it pass successfully.

@dudley-ibm
Copy link
Contributor Author

Sure thing. If you scroll down to the bottom of this page you'll see that one of "checks" was unsuccessful. I was trying to point you in a direction that would hopefully make it pass successfully.

Okay, I appreciate your help. Do I just switch to that branch in Terminal and run that line you suggested? Not sure otherwise how to get to the 'root of the project'.

@sstrubberg
Copy link
Member

Sure thing. If you scroll down to the bottom of this page you'll see that one of "checks" was unsuccessful. I was trying to point you in a direction that would hopefully make it pass successfully.

Okay, I appreciate your help. Do I just switch to that branch in Terminal and run that line you suggested? Not sure otherwise how to get to the 'root of the project'.

Yep, pretty much. When I say "the root of the project", i mean to make sure your terminal is in the carbon directory.

@sstrubberg
Copy link
Member

@dudley-ibm Just wanted to give you an update. I brought down your changes to my machine and tried running the test, but unfortunately, i didn't get the same error. In fact, mine passed, which is even more curious. I'll check in with Josh when he returns from PTO next week.

@dudley-ibm
Copy link
Contributor Author

Thanks for the update @sstrubberg. Does that mean the PR is processing normally now or do you need anything else from me for that to happen?

@dudley-ibm dudley-ibm requested a review from a team as a code owner August 30, 2021 15:01
@sstrubberg sstrubberg merged commit 713f558 into carbon-design-system:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants