-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): add dialog component #9496
feat(react): add dialog component #9496
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: c0b12d7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/613267b5383ece00081bd05f 😎 Browse the preview: https://deploy-preview-9496--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: e9c5b7f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/611c33c142c7dc00075dd643 😎 Browse the preview: https://deploy-preview-9496--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: e9c5b7f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/611c33c100f42600087398b1 😎 Browse the preview: https://deploy-preview-9496--carbon-components-react.netlify.app/ |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: c0b12d7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/613267b5d45bf60008ceef06 😎 Browse the preview: https://deploy-preview-9496--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: c0b12d7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/613267b525971c0007a7a5f3 😎 Browse the preview: https://deploy-preview-9496--carbon-components-react.netlify.app/ |
…at/add-dialog-component
…at/add-dialog-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I had a question about the intended outcome on the attached mp4. When I open multiple dialogs, but close the original, then re-open it, I would expect it to open to where I was last instead of starting from the beginning. Thoughts?
Sep-02-2021.15-55-43.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Focus trapping working as expected, focus returning to open button after closing and able to continue tabbing, and not seeing any accessibility violations. Nice work! 👍🏻 ✅
@sstrubberg I think it's expected since it's closing all the nested dialogs, effectively. The state isn't being kept and would most likely need to be something we add in on top of this implementation 👀 |
This is the first part of #8826 where we would like to add in an official
<Dialog>
component to help with building both modal and nonmodal dialog.This exploration has a storybook story that you can view locally but is currently not enabled in the deployed storybook.
Changelog
New
Changed
Removed
Testing / Reviewing
packages/react
Dialog-story
that saysincludeStories: []