Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multiselect): field-02 background color when placed inside modal #9328

Merged
merged 4 commits into from
Jul 28, 2021
Merged

fix(multiselect): field-02 background color when placed inside modal #9328

merged 4 commits into from
Jul 28, 2021

Conversation

tay1orjones
Copy link
Member

Reported in slack, when a MultiSelect is placed inside a Modal, the input background should be modified (field-02) to match against other inputs including a Dropdown.

Click to expand example screenshot of defect:

image

Changelog

Changed

  • multiselect: background is field-02 when placed inside a modal

Testing / Reviewing

Fix should show all inputs in modal example story have the same background color:

image

@tay1orjones tay1orjones requested a review from a team as a code owner July 26, 2021 21:00
@netlify
Copy link

netlify bot commented Jul 26, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 4d8322c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61016917138ba40007840451

😎 Browse the preview: https://deploy-preview-9328--carbon-react-next.netlify.app

@tay1orjones tay1orjones mentioned this pull request Jul 26, 2021
Closed
59 tasks
@netlify
Copy link

netlify bot commented Jul 26, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 4d8322c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610169178b22e900088a05c5

😎 Browse the preview: https://deploy-preview-9328--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 26, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 4d8322c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61016917fa92b20008f053f1

😎 Browse the preview: https://deploy-preview-9328--carbon-components-react.netlify.app

andreancardona
andreancardona approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kodiakhq kodiakhq bot merged commit ab7a3e7 into carbon-design-system:main Jul 28, 2021
This was referenced Aug 3, 2021
Merged
Merged
@jnm2377 jnm2377 mentioned this pull request Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@tw15egan tw15egan tw15egan approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tay1orjones @joshblack @tw15egan @andreancardona