-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(project): add flat exports for namespaced components #9008
feat(project): add flat exports for namespaced components #9008
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: b8df84e 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60fb14e52ac8550008bbfb05 😎 Browse the preview: https://deploy-preview-9008--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: b8df84e 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60fb14e50c3341000753d923 😎 Browse the preview: https://deploy-preview-9008--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: b8df84e 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60fb14e51cf5a50007c3ead3 😎 Browse the preview: https://deploy-preview-9008--carbon-components-react.netlify.app |
This is ready for review, but I'm unsure how best to fix the tests. The public api snap updates, but the test fails because the components are calling I don't think we want to |
@tay1orjones is there any way to check for a specific warning message? Or a snippet from the message like "Please import and use" so that it will catch all of our deprecation warnings, but still emit the rest? |
@tw15egan thanks for the idea! I pushed an update to do just that, it matches on the "field has been deprecated" substring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great 🔥 Just left a note about the mock strategy that can help out with tests and I think after that should be good to go 🚢
Very much appreciate the suggestions @joshblack - all have been addressed. The mock approach feels much cleaner ✨ 👍 |
Closes #8901
Adds new flat exports for previously namespaced components, like
PasswordInput
, deprecating (with notices) the oldTextInput.PasswordInput
Changelog
New
PasswordInput
,ControlledPasswordInput
, andFilterableMultiSelect
deprecateFieldOnObject()
and deprecation notices for the old exportsTesting / Reviewing